Add plan to do pin tip centring then xray centring#852
Conversation
Codecov Report
@@ Coverage Diff @@
## main DiamondLightSource/hyperion#852 +/- ##
==========================================
+ Coverage 92.78% 92.82% +0.03%
==========================================
Files 46 49 +3
Lines 2301 2397 +96
==========================================
+ Hits 2135 2225 +90
- Misses 166 172 +6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Issue seen on beamline where this arms the eiger twice |
|
Also had issue where we weren't sleeping after setting up the oav params |
Co-authored-by: Tom Willemsen <tomwillemsen1995@gmail.com>
Tom-Willemsen
left a comment
There was a problem hiding this comment.
Happy that my requested changes have been addressed.
check on the beamline if this causes much slowness
Has this been done? Happy for you to do before or after merging as appropriate...
Yh, this has been tested on the beamline and works without being too slow. May be avenues to speed up but probably not required at this stage |
d-perl
left a comment
There was a problem hiding this comment.
looks good, no additional comments over Tom's review. I like the names of the plans.
Fixes #499
Note for setting the zoom I just changed the OAVCentring.json file. This will set all OAV parameters twice but to the same values, check on the beamline if this causes much slowness
To test: