688 849 rename to hyperion#864
Conversation
Codecov Report
@@ Coverage Diff @@
## main #864 +/- ##
==========================================
+ Coverage 92.82% 92.86% +0.04%
==========================================
Files 49 49
Lines 2397 2398 +1
==========================================
+ Hits 2225 2227 +2
+ Misses 172 171 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
GDA change here https://gerrit.diamond.ac.uk/c/gda/gda-mx/+/39802 |
DominicOram
left a comment
DominicOram
left a comment
There was a problem hiding this comment.
Thanks, I caught a few bits but I wouldn't be surprised if we're shaking this out for weeks. There's a few artemis references in comments in dodal, can we change those too?
| fi | ||
|
|
||
| pkill -f "python -m artemis" | ||
| pkill -f "python -m hyperion" |
There was a problem hiding this comment.
Nit: This is going to suprise us when the old one doesn't die when do the swicth. I suggest leaving in both kills for now, we can remove the Artemis one another day
| "callback_collection_type": FGSCallbackCollection, | ||
| "callback_collection_type": XrayCentreCallbackCollection, | ||
| }, | ||
| "full_grid_scan": { |
There was a problem hiding this comment.
Must: Did you miss this one?
| ) | ||
|
|
||
| patch = functools.partial(unittest.mock.patch, autospec=True) | ||
| DONE_STATUS = Status(done=True, success=True) |
There was a problem hiding this comment.
Should: This isn't used?
|
|
||
| class ZocaloInteractor: | ||
| def __init__(self, environment: str = "artemis"): | ||
| def __init__(self, environment: str = "hyperion"): |
There was a problem hiding this comment.
Must: Changing this will require changes in zocalo, can you not change it and make an issue
| "id": "c7c601fc-5090-4a0c-a4f3-e757968eeca2", | ||
| "rev": 1, | ||
| "v": "1", | ||
| "name": "Artemis TCP Input", |
There was a problem hiding this comment.
Should: Whilst I don't think this breaks anything I think we should keep the same for now and change it all together in #801
| [metadata] | ||
| name = python-artemis | ||
| name = hyperion | ||
| description = 3D gridscans using BlueSky and Ophyd |
There was a problem hiding this comment.
Should: Can you change this description too? On the repo I used Unattended Data Collection using BlueSky / Ophyd
2 participants
Fixes #688 and fixes #849
Renames lots of stuff