This repository was archived by the owner on Sep 2, 2024. It is now read-only.
Fix unit test for newer dodal#866
Merged
Merged
Conversation
DominicOram
approved these changes
Aug 22, 2023
DominicOram
left a comment
DominicOram
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
dodalin DiamondLightSource/dodal#143 thedevice_instantiationinterface was changed to accept a parameter calleddevice_factoryinstead ofdevice(to avoid ambiguity). A test in hyperion was patching these internals of dodal so needs updating (just use a positional arg instead to not care about parameter name).