Skip to content
This repository was archived by the owner on Sep 2, 2024. It is now read-only.

More renaming some files to Hyperion#884

Merged
DominicOram merged 4 commits into
DiamondLightSource:mainfrom
GonReina:main
Sep 6, 2023
Merged

More renaming some files to Hyperion#884
DominicOram merged 4 commits into
DiamondLightSource:mainfrom
GonReina:main

Conversation

@GonReina

@GonReina GonReina commented Sep 4, 2023

Copy link
Copy Markdown
Contributor

Fixes #873
Renamed 3 files that were still named artemis as mentioned by @DominicOram

@DominicOram

Copy link
Copy Markdown
Collaborator

This is good, thank you! We need to correspondingly change the wiki. e.g. https://github.com/DiamondLightSource/hyperion/wiki/Getting-Started-as-a-Developer. I can do that

@DominicOram DominicOram changed the title Closes #873 More renaming some files to Hyperion Sep 6, 2023

@DominicOram DominicOram left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On second thoughts, I think we can get away with just calling them both just hyperion.code-workspace i.e. drop the python bit

@GonReina GonReina left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done as requested, dropped the python- in .vscode/hyperion.code-workspace

@DominicOram DominicOram left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to be pedantic, can we drop the python part of the dodal-nexgen file too?

@GonReina GonReina left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries, should be done now!

@DominicOram DominicOram left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks. I've changed the name in the wiki and will merge this. What brought you to the repo @Gon-reina? If you're interested in learning some context of what we're doing see here

@DominicOram
DominicOram merged commit 0166ef3 into DiamondLightSource:main Sep 6, 2023
@GonReina

GonReina commented Sep 6, 2023

Copy link
Copy Markdown
Contributor Author

Well I've looking for interesting python based repositories to contribute to and I am a physicist by training, thought this was pretty interesting. I have experience as a programmer too I just haven't worked on open source projects and I thought it would look good on my cv/profile. I just read through your poster and sounds very cool, I have worked with flask before and have dabbled in data analysis pipelines with MATLAB. I am more than happy to help with more stuff as well, maybe some actual coding, will read through the issues!

@DominicOram

Copy link
Copy Markdown
Collaborator

Great! I'm afraid I won't have time in the foreseeable future to talk you through any of the issues and a lot of them probably require quite a bit of background but if you find something you think you might have enough background to do then feel free to comment on it to say you're going to give it a go and we'll try and answer any questions you have.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Files still named Artemis

2 participants