Skip to content
This repository was archived by the owner on Sep 2, 2024. It is now read-only.

Use the constants for setting xbpm feedback paused#935

Merged
DominicOram merged 3 commits into
mainfrom
921_xbpm_pause_other_way_round
Oct 12, 2023
Merged

Use the constants for setting xbpm feedback paused#935
DominicOram merged 3 commits into
mainfrom
921_xbpm_pause_other_way_round

Conversation

@DominicOram

Copy link
Copy Markdown
Collaborator

Fixes #921

Link to dodal PR (if required): DiamondLightSource/dodal#196

To test:

  1. Confirm tests pass

@codecov

codecov Bot commented Oct 12, 2023

Copy link
Copy Markdown

Codecov Report

Merging #935 (0f48566) into main (c5db290) will increase coverage by 93.33%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##           main     #935       +/-   ##
=========================================
+ Coverage      0   93.33%   +93.33%     
=========================================
  Files         0       52       +52     
  Lines         0     2506     +2506     
=========================================
+ Hits          0     2339     +2339     
- Misses        0      167      +167     
Files Coverage Δ
src/hyperion/device_setup_plans/xbpm_feedback.py 100.00% <100.00%> (ø)

... and 51 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@noemifrisina noemifrisina left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay, thanks

@DominicOram
DominicOram merged commit ed29f84 into main Oct 12, 2023
@DominicOram
DominicOram deleted the 921_xbpm_pause_other_way_round branch October 12, 2023 17:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

XBPM feedback: Writing 0 to the PV pauses it

2 participants