This repository was archived by the owner on Sep 2, 2024. It is now read-only.
Add units to dwell time#941
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main DiamondLightSource/hyperion#941 +/- ##
=======================================
Coverage 93.33% 93.33%
=======================================
Files 52 52
Lines 2506 2506
=======================================
Hits 2339 2339
Misses 167 167
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
noemifrisina
approved these changes
Oct 23, 2023
noemifrisina
left a comment
Contributor
There was a problem hiding this comment.
Looks okay, thanks!
Question: is there also a change in GDA to go along with this?
Collaborator
Author
|
Good spot, yes we will need a GDA change too |
Collaborator
Author
|
Actually, that code in GDA will be removed soon anyway (DiamondLightSource/mx-bluesky#347) so we should just do that instead |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #940
Link to dodal PR (if required): DiamondLightSource/dodal#213
To test: