Skip to content
This repository was archived by the owner on Sep 2, 2024. It is now read-only.

Add units to dwell time#941

Merged
DominicOram merged 2 commits into
mainfrom
940_dwell_time_units
Oct 23, 2023
Merged

Add units to dwell time#941
DominicOram merged 2 commits into
mainfrom
940_dwell_time_units

Conversation

@DominicOram

Copy link
Copy Markdown
Collaborator

Fixes #940

Link to dodal PR (if required): DiamondLightSource/dodal#213

To test:

  1. Confirm tests pass

@codecov

codecov Bot commented Oct 23, 2023

Copy link
Copy Markdown

Codecov Report

Merging #941 (c587a5e) into main (ed29f84) will not change coverage.
Report is 10 commits behind head on main.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     DiamondLightSource/hyperion#941   +/-   ##
=======================================
  Coverage   93.33%   93.33%           
=======================================
  Files          52       52           
  Lines        2506     2506           
=======================================
  Hits         2339     2339           
  Misses        167      167           
Files Coverage Δ
...l_interaction/callbacks/grid_detection_callback.py 100.00% <ø> (ø)
...plan_specific/stepped_grid_scan_internal_params.py 65.55% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@noemifrisina noemifrisina left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay, thanks!

Question: is there also a change in GDA to go along with this?

@DominicOram

Copy link
Copy Markdown
Collaborator Author

Good spot, yes we will need a GDA change too

@DominicOram

Copy link
Copy Markdown
Collaborator Author

Actually, that code in GDA will be removed soon anyway (DiamondLightSource/mx-bluesky#347) so we should just do that instead

@DominicOram
DominicOram merged commit f634e7b into main Oct 23, 2023
@DominicOram
DominicOram deleted the 940_dwell_time_units branch October 23, 2023 13:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add units to dwell time

2 participants