This repository was archived by the owner on Sep 2, 2024. It is now read-only.
(#891) Renamed plans to reflect more closely what they do#943
Merged
Conversation
d-perl
approved these changes
Nov 2, 2023
d-perl
left a comment
d-perl
left a comment
Contributor
There was a problem hiding this comment.
Great, this is much more readable, thank you
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #891
Changed names of
ISPYB_PLAN_NAMEandISPYB_UPDATING_COLLECTIONtoISPYB_HARDWARE_READ_PLANand ISPYB_TRANSMISSION_FLUX_READ_PLANrespectively following suggesting from #937 (comment)To test: