Skip to content
This repository was archived by the owner on Sep 2, 2024. It is now read-only.

Use new OAV parameter definition#982

Merged
noemifrisina merged 11 commits into
mainfrom
dodal_224_refactor_oav_params
Nov 27, 2023
Merged

Use new OAV parameter definition#982
noemifrisina merged 11 commits into
mainfrom
dodal_224_refactor_oav_params

Conversation

@noemifrisina

Copy link
Copy Markdown
Contributor

Follows changes in the OAVParameters in dodal.

Link to dodal PR (if required): #239

To test:

  1. Check that the changes haven't affected the plans
  2. Run tests

@DominicOram DominicOram left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but I think some of the failing tests are legitimate

@noemifrisina

Copy link
Copy Markdown
Contributor Author

Yes, they are. It's what I was trying to fix yesterday with the update_on_zoom not being called - still working on it.
Sorry, forgot to set this back as draft in the meantime ...

@codecov

codecov Bot commented Nov 23, 2023

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (372887a) 93.67% compared to head (2794cb7) 93.67%.
Report is 1 commits behind head on main.

❗ Current head 2794cb7 differs from pull request most recent head bccb13a. Consider uploading reports for the commit bccb13a to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #982   +/-   ##
=======================================
  Coverage   93.67%   93.67%           
=======================================
  Files          56       56           
  Lines        2704     2704           
=======================================
  Hits         2533     2533           
  Misses        171      171           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DominicOram DominicOram left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you! I tidied up the tests but otherwise works well.

@noemifrisina
noemifrisina merged commit 887b997 into main Nov 27, 2023
@noemifrisina
noemifrisina deleted the dodal_224_refactor_oav_params branch November 27, 2023 14:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants