Skip to content

Conversation

@stephen-riggs
Copy link
Contributor

We had a TomographyProcessingParameters table in the database which just contained the tilt offset. This removes that table and renames the TomographyPreprocessingParameters to just be TomographyProcessingParameters.

I've also removed manual_tilt_offset from the client side entirely, as it is calculated server-side. I expect that will mean it disappears from the TUI display.

The renaming in particular is a high-risk change, which needs a test build and run before we can say this works.

@stephen-riggs stephen-riggs requested a review from tieneupin April 10, 2025 15:28
@tieneupin
Copy link
Contributor

Will test this after testing PR #567

@codecov
Copy link

codecov bot commented Apr 10, 2025

Codecov Report

Attention: Patch coverage is 47.36842% with 10 lines in your changes missing coverage. Please review.

Project coverage is 30.19%. Comparing base (e1fa429) to head (783bab3).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #572      +/-   ##
==========================================
- Coverage   30.21%   30.19%   -0.03%     
==========================================
  Files          80       80              
  Lines       10510    10468      -42     
  Branches     1401     1397       -4     
==========================================
- Hits         3176     3161      -15     
+ Misses       7229     7202      -27     
  Partials      105      105              
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@tieneupin tieneupin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than one comment recommending that the function name should match the table it is interacting with, it all looks good and runs smoothly on both the TUI and instrument server. Thanks for doing this!

This will require a database reset, so I will reserve merging until we've all been able to discuss it again in person.

@stephen-riggs stephen-riggs merged commit efda46c into main Apr 16, 2025
17 checks passed
@stephen-riggs stephen-riggs deleted the no-tomo-tilt-input branch April 16, 2025 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants