Skip to content

Initial model cube name fix#838

Merged
stephen-riggs merged 1 commit into
mainfrom
ini-mod-cube
Jul 13, 2026
Merged

Initial model cube name fix#838
stephen-riggs merged 1 commit into
mainfrom
ini-mod-cube

Conversation

@stephen-riggs

Copy link
Copy Markdown
Contributor

I found I had this uncommitted from a while ago. It's a direct bug in the user-supplied initial model logic

@stephen-riggs
stephen-riggs requested a review from tieneupin July 6, 2026 14:10
@codecov

codecov Bot commented Jul 6, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.31%. Comparing base (975c2f3) to head (1ba5c93).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #838      +/-   ##
==========================================
- Coverage   53.31%   53.31%   -0.01%     
==========================================
  Files         101      101              
  Lines       10933    10934       +1     
  Branches     1452     1452              
==========================================
  Hits         5829     5829              
- Misses       4788     4789       +1     
  Partials      316      316              
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tieneupin tieneupin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, looks fine! Does this urgently need to go in? Would it be too arduous to add a test for this?

@stephen-riggs
stephen-riggs merged commit 0deb999 into main Jul 13, 2026
17 checks passed
@stephen-riggs
stephen-riggs deleted the ini-mod-cube branch July 13, 2026 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants