chore(k8s): wire prod Keycloak config and real CORS origin#209
Merged
Conversation
Replaces the app.example.com placeholder with the real prod ingress hostname (smartem.diamond.ac.uk) and adds the Keycloak block so the backend will accept tokens once the DLS production Keycloak clients exist. KEYCLOAK_REALM and KEYCLOAK_VERIFY_ISS are intentionally left as TODOs pending confirmation from DLS Keycloak admins.
This was referenced May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two prod-deploy blockers fixed in
k8s/environments/production/configmap.yaml:CORS_ALLOWED_ORIGINSwas thehttps://app.example.complaceholder. Set to the real prod ingress hostnamehttps://smartem.diamond.ac.uk(matchesproduction/ingress.yaml).smartem-decisions#285) so without this the prod backend will 403 every non-exempt request. Added:KEYCLOAK_URL: https://identity.diamond.ac.ukKEYCLOAK_ALLOWED_AZP: SmartEM_User,SmartEM_AgentKEYCLOAK_REALMandKEYCLOAK_VERIFY_ISSleft as TODO comments pending confirmation from DLS Keycloak admins (per "verify or omit" rule for DLS-facing config).Test plan
KEYCLOAK_REALMandKEYCLOAK_VERIFY_ISS: "true"before go-live