chore(k8s): drop in-cluster managed-service manifests from staging and prod#210
Merged
Merged
Conversation
…d prod PostgreSQL, RabbitMQ, MongoDB, Elasticsearch and Keycloak are externally managed services provided by DLS infra in staging and production. The in-cluster Deployment/StatefulSet manifests were dead config — left over from the development overlay structure. Removed from both overlays: - postgres.yaml - rabbitmq.yaml - mongodb.yaml - elasticsearch.yaml Also updated both configmaps: - POSTGRES_HOST and RABBITMQ_HOST now placeholder OVERRIDE-FROM-ENV values so a deploy without .env override fails fast with a clear signal rather than trying to resolve the now-deleted in-cluster services. - Dropped ADMINER_PORT (adminer is not deployed in staging/prod). - Staging CORS_ALLOWED_ORIGINS corrected from staging.example.com placeholder to smartem-staging.diamond.ac.uk (matches the ingress host). Development overlay is unchanged - dev still spins up its own infra.
github-actions
Bot
added
the
devops
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PostgreSQL, RabbitMQ, MongoDB, Elasticsearch and Keycloak are externally managed services in staging and production (provided by DLS infra). The in-cluster manifests for them were dead config left over from the development overlay structure.
Removed (8 files)
k8s/environments/{staging,production}/postgres.yamlk8s/environments/{staging,production}/rabbitmq.yamlk8s/environments/{staging,production}/mongodb.yamlk8s/environments/{staging,production}/elasticsearch.yamlDropped from both
kustomization.yamlresource lists.Configmap changes (both envs)
POSTGRES_HOSTandRABBITMQ_HOSTset to"OVERRIDE-FROM-ENV"placeholders so a deploy without.env.{staging,production}override fails fast with a clear signal rather than silently trying to resolve the now-deleted in-cluster services.ADMINER_PORT(adminer is not deployed in either env).Bonus fix
CORS_ALLOWED_ORIGINScorrected from thestaging.example.complaceholder tosmartem-staging.diamond.ac.uk(matches the ingress host). Same nature of fix as PR chore(k8s): wire prod Keycloak config and real CORS origin #209 which fixed prod.Out of scope
development/overlay is not touched - dev still spins up its own infra locally.Test plan
kubectl kustomize k8s/environments/production/builds successfully (291 lines, no errors)kubectl kustomize k8s/environments/staging/builds successfully (291 lines, no errors).env.staging/.env.production(provided by Dan), backend pods come up and connect to the managed PG/MQ instances