[R1] fix(test): create Better Auth tables in test setup for fresh DBs#8
[R1] fix(test): create Better Auth tables in test setup for fresh DBs#8jeffreyyan wants to merge 1 commit intomainfrom
Conversation
In CI, the Postgres service container starts empty. AppDataSource uses synchronize: true (dev mode), which creates schema for entities in the entities array — but Better Auth's session, account, and verification tables are managed via a migration (AddBetterAuthTables), not as entities. synchronize doesn't know about them, so on a fresh DB those tables don't exist. Any test path that touches Better Auth (e.g., admin.test.ts inviteUser flow → sendInvitationEmail → auth.api.signInMagicLink) hits "relation does not exist". Better Auth surfaces these as unhandled rejections that can crash the vitest worker, producing the silent test-step exit observed in PR #7's Full Test Suite job (no vitest summary, process dies mid-run). Fix: in test-setup's beforeAll, after AppDataSource.initialize(), check whether the verification table exists and run the BA migration if not. Idempotent — no-op against the dev DB where the tables already exist (verified locally: 361/361 pass on both fresh and pre-populated DBs).
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the test setup to manually ensure that migration-managed tables for Better Auth are created during database initialization, preventing errors in environments like CI where these tables might be missing. The review feedback highlights a potential race condition when running tests in parallel and suggests moving this logic to a global setup or using advisory locks. Additionally, it is recommended to use TypeORM's built-in hasTable method instead of raw SQL for checking table existence.
| const qr = AppDataSource.createQueryRunner(); | ||
| try { | ||
| const exists = await qr.query( | ||
| `SELECT 1 FROM information_schema.tables WHERE table_schema = 'public' AND table_name = 'verification' LIMIT 1` | ||
| ); | ||
| if (exists.length === 0) { | ||
| await new AddBetterAuthTables1775574200000().up(qr); | ||
| } | ||
| } finally { | ||
| await qr.release(); | ||
| } |
There was a problem hiding this comment.
This manual migration check is susceptible to race conditions when running tests in parallel (Vitest's default mode). Multiple worker processes may simultaneously detect the missing table and attempt to run the migration, leading to QueryFailedError: relation "session" already exists. To resolve this, consider moving the database initialization and migration logic to a Vitest globalSetup file, which runs exactly once before any test workers are started. Alternatively, wrap this logic in a database-level advisory lock.
| const exists = await qr.query( | ||
| `SELECT 1 FROM information_schema.tables WHERE table_schema = 'public' AND table_name = 'verification' LIMIT 1` | ||
| ); | ||
| if (exists.length === 0) { |
There was a problem hiding this comment.
Instead of executing raw SQL against information_schema, use the built-in queryRunner.hasTable() method. It is more idiomatic for TypeORM and automatically handles schema and dialect specifics.
if (!(await qr.hasTable("verification"))) {1 participant
Summary
Fixes the deterministic CI failure on PR #7's Full Test Suite, where the test step died silently mid-run (no vitest summary, process exits during
upload.test.ts).Root cause
AppDataSourceusessynchronize: isDevwhich creates schema for the entities listed indata-source.ts. Better Auth'ssession,account, andverificationtables are NOT TypeORM entities — they're managed by theAddBetterAuthTablesmigration. On a fresh DB (CI's Postgres service container),synchronizedoesn't create them, so any test that touches Better Auth (e.g.,admin.test.ts'sinviteUser→auth.api.signInMagicLink) hitsrelation "verification" does not exist. Better Auth surfaces these as unhandled rejections that crash the vitest worker — producing the silent exit pattern.Locally this never reproduced because the dev
chat-explorerDB has had migrations run at some point (the BA tables exist). I verified by spinning up a freshchat-explorer-testDB and runningpnpm testagainst it — same class of failures.Fix
In
src/server/test-setup.ts, afterAppDataSource.initialize(), checkinformation_schema.tablesfor theverificationtable. If absent, runAddBetterAuthTables.up(). Idempotent — no-op against the dev DB where the tables already exist.Verification
pnpm typecheck— cleanchat-explorer-testDB. Without the fix: 1 file failed, 4 tests failed (all in BA-touching paths). With the fix: 357 pass, 4 fail inupload.http.test.ts(unrelated — those need a running HTTP server which my local experiment didn't provide).chat-explorerDB (BA tables already present) — 361/361 pass.CI should now pass the Full Test Suite. After this merges, I'll rebase PR #7 (the security-bumps PR) on
mainso its CI rerun also passes.🤖 Generated with Claude Code