[R1] ci: scope Full Test Suite to PRs that touch src/**#9
Open
jeffreyyan wants to merge 2 commits intomainfrom
Open
[R1] ci: scope Full Test Suite to PRs that touch src/**#9jeffreyyan wants to merge 2 commits intomainfrom
jeffreyyan wants to merge 2 commits intomainfrom
Conversation
Splits ci.yml into two workflows: - ci.yml — typecheck + client unit tests, runs on all pushes/PRs (unchanged) - ci-full.yml — Postgres-backed integration suite, runs only on PRs that change src/**, vitest.config.ts, tsconfig*.json, or this workflow file Rationale: pure-dependency PRs (e.g., Dependabot-triggered version bumps) and docs-only PRs don't need the full integration suite — typecheck + client unit tests cover the relevant signal. Beyond cost, the integration suite is currently flaky for unrelated reasons (mid-test silent exit during upload tests) — narrowing its trigger removes the false-negative from PRs where it was never load-bearing. To force a run on an excluded PR, touch any file under src/.
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
…ges don't need integration suite)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Splits
ci.ymlinto two workflows so the integration suite (Full Test Suite) runs only on PRs that change application code or test configuration. Pure-dependency PRs (e.g., Dependabot bumps) and docs-only PRs are covered by typecheck + client unit tests inci.yml.Why
Two reasons:
package.json/pnpm-lock.yaml-only changes. The typecheck job already catches API breakage from dep bumps.Trigger paths
Full Test Suiteruns when a PR changes:src/**vitest.config.tstsconfig*.json.github/workflows/ci-full.ymlTo force a run on an otherwise-excluded PR, touch any file under
src/.Verification
src/**changes here, so Full Test Suite is correctly skipped — that's the expected behavior for this exact PR)Follow-ups
fix/ci-better-auth-tables) was a partial improvement that didn't address the root cause; will be re-evaluated separately.🤖 Generated with Claude Code