fix pixiv private timelines#2252
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8ef6e2f599
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| PixivPrivateFollowing, | ||
| PixivPrivateBookmarks, |
There was a problem hiding this comment.
Add Apple mappings for new Pixiv tab strings
When the Apple target imports this updated UiStrings enum, appleApp/Shared/FlareAppleCore/Sources/FlareAppleCore/PresentationMappings.swift:117-127 still exhaustively switches only the old cases and has no default. Adding these two cases without matching .pixivPrivateFollowing and .pixivPrivateBookmarks mappings breaks Apple builds that compile UiStrings.text, so the new Pixiv tabs need to be added to that Swift mapping as well.
Useful? React with 👍 / 👎.
Summary
restrict=private.UiStringsentries and English titles for the new Pixiv private timeline entries across Android, Compose/Desktop, Web, and Apple.Validation
./gradlew :social:pixiv:compileKotlinJvm :compose-ui:compileKotlinJvm./gradlew :app:compileDebugKotlin :desktopApp:compileKotlinenv PATH=/Users/tlaster/.cache/codex-runtimes/codex-primary-runtime/dependencies/node/bin:/Users/tlaster/.cache/codex-runtimes/codex-primary-runtime/dependencies/bin:/usr/local/bin:/opt/homebrew/bin:/usr/bin:/bin:/usr/sbin:/sbin ./gradlew --no-daemon :web-shared:wasmJsBrowserDevelopmentLibraryDistribution./node_modules/.bin/svelte-kit sync./node_modules/.bin/svelte-check --tsconfig ./tsconfig.jsonjq empty appleApp/Shared/FlareAppleResource/Resources/Localizable.xcstringsxcodebuild -project appleApp/Flare.xcodeproj -scheme FlareAppleCore -configuration Debug -derivedDataPath /private/tmp/flare-apple-core build CODE_SIGNING_ALLOWED=NOFixes #2249