Skip to content

fix pixiv private timelines#2252

Merged
Tlaster merged 2 commits into
masterfrom
bugfix/pixiv-private-restrict
Jun 26, 2026
Merged

fix pixiv private timelines#2252
Tlaster merged 2 commits into
masterfrom
bugfix/pixiv-private-restrict

Conversation

@Tlaster

@Tlaster Tlaster commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add separate Pixiv private following and private bookmarks timelines using restrict=private.
  • Add UiStrings entries and English titles for the new Pixiv private timeline entries across Android, Compose/Desktop, Web, and Apple.
  • Preserve existing public Pixiv timeline ids and paging keys.

Validation

  • ./gradlew :social:pixiv:compileKotlinJvm :compose-ui:compileKotlinJvm
  • ./gradlew :app:compileDebugKotlin :desktopApp:compileKotlin
  • env PATH=/Users/tlaster/.cache/codex-runtimes/codex-primary-runtime/dependencies/node/bin:/Users/tlaster/.cache/codex-runtimes/codex-primary-runtime/dependencies/bin:/usr/local/bin:/opt/homebrew/bin:/usr/bin:/bin:/usr/sbin:/sbin ./gradlew --no-daemon :web-shared:wasmJsBrowserDevelopmentLibraryDistribution
  • ./node_modules/.bin/svelte-kit sync
  • ./node_modules/.bin/svelte-check --tsconfig ./tsconfig.json
  • jq empty appleApp/Shared/FlareAppleResource/Resources/Localizable.xcstrings
  • xcodebuild -project appleApp/Flare.xcodeproj -scheme FlareAppleCore -configuration Debug -derivedDataPath /private/tmp/flare-apple-core build CODE_SIGNING_ALLOWED=NO

Fixes #2249

@Tlaster Tlaster marked this pull request as ready for review June 26, 2026 08:53

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8ef6e2f599

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +59 to +60
PixivPrivateFollowing,
PixivPrivateBookmarks,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Add Apple mappings for new Pixiv tab strings

When the Apple target imports this updated UiStrings enum, appleApp/Shared/FlareAppleCore/Sources/FlareAppleCore/PresentationMappings.swift:117-127 still exhaustively switches only the old cases and has no default. Adding these two cases without matching .pixivPrivateFollowing and .pixivPrivateBookmarks mappings breaks Apple builds that compile UiStrings.text, so the new Pixiv tabs need to be added to that Swift mapping as well.

Useful? React with 👍 / 👎.

@Tlaster Tlaster merged commit 01301cb into master Jun 26, 2026
9 checks passed
@Tlaster Tlaster deleted the bugfix/pixiv-private-restrict branch June 26, 2026 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] Pixiv can't display hidden follows/bookmarks.

1 participant