Skip to content

fix(timeline): prevent duplicate threads in chronological mixed feeds - #2489

Merged
Tlaster merged 1 commit into
masterfrom
bugfix/mixed-chronological-thread-duplicates
Sep 7, 2026
Merged

fix(timeline): prevent duplicate threads in chronological mixed feeds#2489
Tlaster merged 1 commit into
masterfrom
bugfix/mixed-chronological-thread-duplicates

Conversation

@Tlaster

@Tlaster Tlaster commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Chronological mixed timelines could repeat a thread during the initial load: [1…9] was followed by [1…8], even when Bluesky and Mastodon each returned only one remote page. Collapsed parents remained in staging because only the final timeline root rows were counted as consumed.

Include inline-parent IDs in the consumed set before reading staged items again. The SQL query returns only IDs and scopes references to existing roots in the current timeline.

Validation:

  • 35 JVM tests passed: ./gradlew :shared:jvmTest --tests '*MixedRemoteMediatorTest' --tests '*PagingTimelineDaoTest'.
  • Added two-post and nine-post initial-load regressions; both failed before the fix and pass afterward.
  • Added DAO coverage for reference types, timeline isolation, duplicate IDs, and references left behind by deleted roots.
  • Ran ktlint format/check on all four changed Kotlin files and git diff --check.

Fixes #2166.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 7, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-07T03:00:33.737073Z 6056e80 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Tlaster
Tlaster merged commit 1c97b27 into master Sep 7, 2026
9 checks passed
@Tlaster
Tlaster deleted the bugfix/mixed-chronological-thread-duplicates branch September 7, 2026 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bluesky Posts are repeating the entire thread per reply

1 participant