Cheap LFS materialize cancel/summary fixes from verified bug audit / 大檔還原取消同總結修正 #2
DingDingChae
started this conversation in
Show and tell
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
What changed / 改咗啲乜
A multi-agent bug audit of the last fifteen commits (nine finder lenses; every finding adversarially verified by three independent reviewers) confirmed seven defects. This task fixed the three user-facing Cheap LFS materialize-flow bugs in commit
e3fb8c8664, merged with the concurrent legacy-deletion guard work in7274960257:撳「全部還原」嘅取消掣,宜家成個 repo 排緊隊嘅批次都會一齊停低;面板會照實報告失敗數目;取消之後清單即刻重新載入,唔會留低過時狀態。
Verification / 驗證
tsc --noEmit, ESLint, and Prettier clean on every touched file.app/test/unit/cheap-lfs298/298,ui/cheap-lfs-test.tsx20/20 (three new behavioral tests),submodule-mutation-guard-test.ts7/7,submodule-repository-navigation-test.ts21/21 — the last two were already failing at the previous HEAD against an outdated dispose-map shape and were repaired here. Post-merge rerun: 349/349.Remaining work / 未做嘅嘢
Verified but not yet fixed: non-deleted
.git*selections with a symlinked parent or multi-link leaf still fail the whole commit via an unhandledCheapLfsTrackedPathError(the merged legacy-deletion guard covers the deleted-path case);maybeAutoMaterializeCheapLfsawaiting the full per-checkout queue can stall awaited repository-selection chains; the cloud-compression action rejects documented-valid exactly-2-GiB legacy parts and lacks a stdinerrorlistener. Details inHANDOFF.md.All reactions