Use f-strings instead of % formatting or str.format#167
Merged
kevinkjt2000 merged 2 commits intoDinnerbone:masterfrom Nov 19, 2021
ItsDrike:fstrings
Merged
Use f-strings instead of % formatting or str.format#167kevinkjt2000 merged 2 commits intoDinnerbone:masterfrom ItsDrike:fstrings
kevinkjt2000 merged 2 commits intoDinnerbone:masterfrom
ItsDrike:fstrings
Conversation
kevinkjt2000
approved these changes
Nov 19, 2021
|
|
||
| click.echo(f"version: v{response.version.name} (protocol {response.version.protocol})") | ||
| click.echo(f'description: "{response.description}"') | ||
| click.echo(f"players: {response.players.online}/{response.players.max} {player_sample}") |
Collaborator
There was a problem hiding this comment.
Much more readable than before, nice!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since python 3.6, support for "f-strings" was added, this allows us to format strings in a very simple way:
This is much more readable than using
str.formator the%formatting notation.I assume the reason these older ways to format strings was to keep the library compatible with older python versions, however at the moment, this library supports >=3.6 which allows us to utilize these f-strings instead of the less readable methods.