Annotate alternative constructors with Self#205
Merged
kevinkjt2000 merged 1 commit intoDinnerbone:masterfrom Feb 2, 2022
ItsDrike:self-type-annotation
Merged
Annotate alternative constructors with Self#205kevinkjt2000 merged 1 commit intoDinnerbone:masterfrom ItsDrike:self-type-annotation
kevinkjt2000 merged 1 commit intoDinnerbone:masterfrom
ItsDrike:self-type-annotation
Conversation
This was referenced Mar 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After an approval from discord, this PR uses the recently added
Selftype annotation from PEP 673, scheduled to be added into python in 3.11 to annotate alternative constructors easily without having to make individual type variables for each class that needs them just to support subclassing.Even though this type annotation isn't yet in python's standard library, the
typing_extensionspackage does already contain it and pyright type checker does already full support it.