wpt: handle missing/unresolvable ref files gracefully; exclude tools/resources dirs - #660
Open
nicoburns wants to merge 1 commit into
Open
wpt: handle missing/unresolvable ref files gracefully; exclude tools/resources dirs#660nicoburns wants to merge 1 commit into
nicoburns wants to merge 1 commit into
Conversation
…ls/resources dirs
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
17 tests crashed in
process_ref_testwhen the<link rel=match>reference couldn't be resolved or read:href="about:blank"panicked onref_url.path().strip_prefix('/').unwrap()(the URL has no leading-slash path). Anabout:blankref means "matches a blank page", so it is now rendered as an empty document and compared normally (several of these tests now PASS).css-transforms/css-transform-inherit-rotate.htmlpointing at a deletedttwf-reftest-tutorial-ref.html) panicked onfs::read_to_string(...).expect("Ref file not found."). Unresolvable hrefs, unsupported schemes, and unreadable ref files now log a warning and returnSubtestCounts::ZERO_OF_ZERO(reported as SKIP).css/css-images/tools/(with literalREPLACEME_REFERENCE_FILENAMErefs) and helpers underresources/are not tests at all:filter_pathnow excludestoolsandresourcesdirectories from collection, matching the upstream WPT manifest rules.Crash count for the affected dirs (CSS2/generated-content, css-break, css-images, css-masking, css-overflow, css-transforms, css-view-transitions): 16 of the 17 group crashes eliminated; the remaining one (
overflow-body-propagation-013.html) then crashes in the engine (Document node queued as inline root when:rootisdisplay:none) and is fixed separately in #661-to-be (layout classification PR).Link to Devin session: https://dioxus.staging.devinenterprise.com/sessions/f1a0d6696eaa4076a48f366a24bfd26f
Requested by: @nicoburns
WPT results
4 newly passing, 0 newly failing (net +4), 4 other status changes, 73 removed tests.
Full diff (81 changed tests)
Generated by the WPT workflow.