fix(changed): a change with nothing mutable in it is not a failure - #15
Merged
Conversation
Found by this repository's own gate the day after it went green, on the commit
that added `-v`: one `switch` case, a scope of one file, ZERO mutants, and a red
run that had found nothing wrong with anything.
scope since v0.9.0: 1 file(s), 1 with byte ranges
⨯ Score: -1.00 (minimum: 0.50)
The calculator reports -1 for an empty run, which is below every threshold, so
a scope that produced no mutants and a suite that failed were the same answer.
Run and RunStaged keep that refusal -- a repository or an index that yields
nothing is a scope somebody configured wrong. A diff is not: a new switch case,
a comment, a rename are all legitimately unmutatable, and failing a gate for one
is failing a change for being correct.
The count is read through an optional interface, the way RemoveAll and the
gated counters already are. The reporter decorators forward it, and that is the
part that would have been missed: without forwarding, the count is unreadable
exactly when the stack is deepest -- the gated run that raised this. Backlog
entry 12's class, caught again, and pinned by a test over gated, verbose, and
gated-over-verbose.
The end-to-end case runs both stacks, because the plain one would have passed
either way.
mutantsPerReleaseOnThisRepository 785 to 789.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by this repository's own gate the day after it went green, on the commit
that added
-v:One added
switchcase. A scope of one file. Zero mutants. And a red runthat had found nothing wrong with anything.
The two answers that looked the same
The score calculator reports
-1for an empty run, which is below everythreshold — so "the scope produced nothing to judge" and "the suite failed"
arrived as the same number.
RunandRunStagedkeep the refusal: a repository or an index that yields nomutants is a scope somebody configured wrong, and that is worth failing on. A
diff is not. A new
switchcase, a comment, a rename are all legitimatelyunmutatable, and failing a gate for one is failing a change for being correct.
The part that would have been missed
The count is read through an optional interface, the way
RemoveAlland thegated counters already are — and the reporter decorators have to forward it.
Without that the count is unreadable exactly when the stack is deepest, which is
the gated run that raised this in the first place. That is backlog entry 12's
class, caught again, so it is pinned by a test over
gated,verbose, andgated-over-verbose.The end-to-end case runs both stacks too, because the plain one would have passed
either way and proved nothing.
Checks
livetreecounters, lint0 issues.mutantsPerReleaseOnThisRepository785 → 789.