Roam: ENG-693 handle node tags with # in front and update placeholder to use # #420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
This was referenced Sep 6, 2025
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Closed
sid597
changed the title
sid597
force-pushed
the
eng-693-handle-in-tag
branch
from
dfcb44b to
94c5a08
Compare
This was referenced Sep 6, 2025
sid597
force-pushed
the
eng-693-handle-in-tag
branch
from
7610dad to
b7e7d4f
Compare
mdroidian
approved these changes
Sep 7, 2025
Contributor
mdroidian
left a comment
mdroidian
left a comment
There was a problem hiding this comment.
This works, but ideally we sanitize the data right when it is input. (so when we call getDiscourseNodes or nodeConfig), that way we can sanitize it just once and always know we are using the same data format.
sid597
force-pushed
the
eng-693-handle-in-tag
branch
from
d7c0aca to
a4215ff
Compare
sid597
force-pushed
the
eng-737-use-node-color-to-style-node-tags
branch
from
c835f68 to
4345e2a
Compare
sid597
force-pushed
the
eng-693-handle-in-tag
branch
from
a4215ff to
ee6ebdf
Compare
sid597
force-pushed
the
eng-737-use-node-color-to-style-node-tags
branch
from
4345e2a to
df5f0b8
Compare
sid597
merged commit fb1b619
into
eng-737-use-node-color-to-style-node-tags
7 of 8 checks passed
sid597
added a commit
that referenced
this pull request
Sep 8, 2025
* modify dom only for node tags * add background color to a nodetag * use it as color not background color * remove unused refresh * Roam: ENG-693 handle node tags with # in front and update placeholder to use # (#420) * use text not tag * Move the new block as first child of the current block (#422)
sid597
added a commit
that referenced
this pull request
Sep 8, 2025
* use getDiscourseNodes * Eng-737 use node color to style node tags (#424) * modify dom only for node tags * add background color to a nodetag * use it as color not background color * remove unused refresh * Roam: ENG-693 handle node tags with # in front and update placeholder to use # (#420) * use text not tag * Move the new block as first child of the current block (#422)
trangdoan982
pushed a commit
that referenced
this pull request
Oct 3, 2025
* use getDiscourseNodes * Eng-737 use node color to style node tags (#424) * modify dom only for node tags * add background color to a nodetag * use it as color not background color * remove unused refresh * Roam: ENG-693 handle node tags with # in front and update placeholder to use # (#420) * use text not tag * Move the new block as first child of the current block (#422)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.loom.com/share/7aaa1d3cb17b4d25ba58451d21c2ed4a?sid=8d65c3d8-861f-44e4-b3c5-92b4a000a5c1