-
Notifications
You must be signed in to change notification settings - Fork 3
ENG-826 inconsistent 'create node' popover for candidate nodes #421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
@coderabbitai full review |
✅ Actions performedFull review triggered. |
📝 WalkthroughWalkthroughUpdates the tag popover positioning logic in renderNodeTagPopup: measures the parent’s bounding rect, sets container and target overlay dimensions to rect.width/height with absolute positioning, removes a redundant rect computation, and adjusts the popover offset to center relative to the tag’s width. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🧹 Nitpick comments (1)
apps/roam/src/utils/renderNodeTagPopup.tsx (1)
29-30: Prefer responsive sizing over fixed px to handle reflow/zoom.Hard-coding
pxwidth/height can drift on font/zoom changes and wrapping. Using 100% keeps the overlay in sync with its wrapper.- reactRoot.style.width = `${rect.width}px`; - reactRoot.style.height = `${rect.height}px`; + reactRoot.style.width = "100%"; + reactRoot.style.height = "100%";
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
apps/roam/src/utils/renderNodeTagPopup.tsx(4 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
- GitHub Check: Graphite / mergeability_check
- GitHub Check: Graphite / mergeability_check
- GitHub Check: Graphite / mergeability_check
- GitHub Check: Graphite / mergeability_check
- GitHub Check: Graphite / mergeability_check
- GitHub Check: Graphite / mergeability_check
- GitHub Check: Graphite / mergeability_check
🔇 Additional comments (1)
apps/roam/src/utils/renderNodeTagPopup.tsx (1)
75-77: Anchoring the target overlay is correct.Adding
top: 0,left: 0, andposition: absoluteon the target improves hitbox alignment with the tag.Also applies to: 79-79
mdroidian
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cdbda8a
into
eng-752-node-formalization-menu-doesnt-pop-up-in-query-results-forr


https://www.loom.com/share/e0ddc797613f49bfa78cd1e7611157fa?sid=ffc11a76-683a-40d1-8d29-767b70181a5f
Summary by CodeRabbit