ENG-829 Move candidate node as child of new discourse node

[sid597]

https://www.loom.com/share/67fc7b2aebaf4753b46ae96716da0e71?sid=4b464ba9-f841-4d8d-b46d-051850011c11

[linear]

ENG-829 formalizing a block with a node tag that contains an image kills the image

[supabase]

This pull request has been ignored for the connected project zytfjzqyijgagqxrzbmz because there are no changes detected in packages/database/supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

---

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

[sid597]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• ENG-829 Move candidate node as child of new discourse node  #422 👈 (View in Graphite)
• Roam: ENG-693 handle node tags with # in front and update placeholder to use # #420 : 1 other dependent PR (#417 )
• Eng-737 use node color to style node tags #424
• Roam: ENG-798 Node Tags breaks Color Highlighter #402 : 1 other dependent PR (#414 )
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[sid597]

@coderabbitai full review

[coderabbitai]

✅ Actions performed

Full review triggered.

[coderabbitai]

📝 Walkthrough

Walkthrough

Modifies CreateNodeDialog to change how a page reference is inserted when a sourceBlockUid is present: instead of updating the source block’s text, it queries the source block’s parent and order, creates a new sibling block with the page reference, and moves the original source block under the new block.

Changes

Cohort / File(s)	Summary
CreateNode placement refactor apps/roam/src/components/CreateNodeDialog.tsx	Import createBlock; when sourceBlockUid exists, query parentUid and order via roamAlphaAPI, create a new block with pageRef under the same parent, then move the original source block to be a child of the new block at order 0. No exported API changes.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor User
  participant CreateNodeDialog
  participant roamAlphaAPI
  participant createBlock

  User->>CreateNodeDialog: Confirm create node (with sourceBlockUid)
  CreateNodeDialog->>roamAlphaAPI: Datalog query to get parentUid, order
  Note right of roamAlphaAPI: Returns parentUid and order of source block
  roamAlphaAPI-->>CreateNodeDialog: parentUid, order

  CreateNodeDialog->>createBlock: Create new block under parentUid with pageRef
  Note right of createBlock: Returns newBlockUid
  createBlock-->>CreateNodeDialog: newBlockUid

  CreateNodeDialog->>roamAlphaAPI: Move sourceBlockUid under newBlockUid at order 0
  Note over CreateNodeDialog,roamAlphaAPI: Source block becomes a child of the pageRef block

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• Roam: ENG-622: Node tag to node conversions #304 — Earlier change to CreateNodeDialog that updated the source block text in-place to a page reference; this PR alters that behavior to create a new block and nest the source block under it.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 3

🧹 Nitpick comments (1)

apps/roam/src/components/CreateNodeDialog.tsx (1)

14-14: Import looks good; drop now-unused updateBlock.

Since you switched to createBlock, updateBlock (Line 6) appears unused; consider removing to keep lint clean.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 66ba630 and f9fc7ad.

📒 Files selected for processing (1)

• apps/roam/src/components/CreateNodeDialog.tsx (3 hunks)

🧰 Additional context used

🧠 Learnings (1)

📚 Learning: 2025-06-22T10:40:52.752Z

Learnt from: sid597
PR: DiscourseGraphs/discourse-graph#232
File: apps/roam/src/utils/getAllDiscourseNodesSince.ts:18-31
Timestamp: 2025-06-22T10:40:52.752Z
Learning: In apps/roam/src/utils/getAllDiscourseNodesSince.ts, the user confirmed that querying for `?title` with `:node/title` and mapping it to the `text` field in the DiscourseGraphContent type is the correct implementation for retrieving discourse node content from Roam Research, despite it appearing to query page titles rather than block text content.

Applied to files:

• apps/roam/src/components/CreateNodeDialog.tsx

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)

• GitHub Check: Graphite / mergeability_check
• GitHub Check: Graphite / mergeability_check
• GitHub Check: Graphite / mergeability_check
• GitHub Check: Graphite / mergeability_check
• GitHub Check: Graphite / mergeability_check
• GitHub Check: Graphite / mergeability_check

[mdroidian]

Consider using roamjs-component functions instead rewriting queries.