[Feat] RAGOps Dashboard 집계 지표 조회 API - #136
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Warning Review limit reached
Next review available in: 50 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthrough관리자용 ChangesRAGOps 대시보드 집계
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)sequenceDiagram
actor 관리자
participant DashboardController
participant DashboardQueryService
participant Repositories
participant WorkerNodeQueryService
participant Clock
관리자->>DashboardController: GET /admin/dashboard/summary
DashboardController->>DashboardQueryService: getSummary()
DashboardQueryService->>Repositories: 문서·작업·검색 집계 조회
DashboardQueryService->>WorkerNodeQueryService: Worker 상태 조회
DashboardQueryService->>Clock: 현재 시각 조회
DashboardQueryService-->>DashboardController: DashboardSummaryResponse
DashboardController-->>관리자: ApiResponse
Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
kangcheolung
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@src/main/java/com/opensource/docgrid/domain/dashboard/controller/DashboardController.java`:
- Around line 30-34: Update the DashboardController OpenAPI description to
remove the claim that status changes are delivered via WebSocket push, and state
that the endpoint returns metrics as a snapshot captured at request time only.
In
`@src/main/java/com/opensource/docgrid/domain/dashboard/dto/response/DashboardSummaryResponse.java`:
- Around line 5-18: 클래스 수준 주석을 추가하십시오.
src/main/java/com/opensource/docgrid/domain/dashboard/dto/response/DashboardSummaryResponse.java:5-18에는
대시보드 스냅샷의 최상위 응답 DTO로서 하위 요약을 조합하는 경계를 설명하고,
src/main/java/com/opensource/docgrid/domain/dashboard/controller/DashboardController.java:22-28에는
관리자 대시보드 조회 HTTP 경계이며 집계를 DashboardQueryService에 위임한다는 책임을 설명하십시오.
In
`@src/main/java/com/opensource/docgrid/domain/dashboard/dto/response/DocumentsSummaryResponse.java`:
- Around line 5-15: 문서 집계 응답의 역할과 포함 범위를 설명하는 클래스 수준 Javadoc을
DocumentsSummaryResponse에 추가하세요.
src/main/java/com/opensource/docgrid/domain/dashboard/dto/response/DocumentsSummaryResponse.java
5-15에는 문서 집계 책임과 외부 응답 DTO 경계를,
src/main/java/com/opensource/docgrid/domain/dashboard/dto/response/JobsSummaryResponse.java
5-19에는 Job 상태 및 평균 처리 시간 집계 책임을,
src/main/java/com/opensource/docgrid/domain/dashboard/dto/response/SearchSummaryResponse.java
5-9에는 최근 검색 집계 책임을,
src/main/java/com/opensource/docgrid/domain/dashboard/dto/response/WorkersSummaryResponse.java
5-12에는 Worker 상태 집계 책임을 각각 설명하는 Javadoc을 record 선언부에 추가하세요.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 79801fa6-93ae-4d6f-b94f-f6ec8d80487e
📒 Files selected for processing (14)
docs/design/kangcheolung-#134-ragops-dashboard-summary.mdsrc/main/java/com/opensource/docgrid/domain/dashboard/controller/DashboardController.javasrc/main/java/com/opensource/docgrid/domain/dashboard/dto/response/DashboardSummaryResponse.javasrc/main/java/com/opensource/docgrid/domain/dashboard/dto/response/DocumentsSummaryResponse.javasrc/main/java/com/opensource/docgrid/domain/dashboard/dto/response/JobsSummaryResponse.javasrc/main/java/com/opensource/docgrid/domain/dashboard/dto/response/SearchSummaryResponse.javasrc/main/java/com/opensource/docgrid/domain/dashboard/dto/response/WorkersSummaryResponse.javasrc/main/java/com/opensource/docgrid/domain/dashboard/service/query/DashboardQueryService.javasrc/main/java/com/opensource/docgrid/domain/document/repository/DocumentRepository.javasrc/main/java/com/opensource/docgrid/domain/embedding/repository/EmbeddingJobRepository.javasrc/main/java/com/opensource/docgrid/domain/search/repository/SearchQueryRepository.javasrc/main/java/com/opensource/docgrid/global/config/SecurityConfig.javasrc/test/java/com/opensource/docgrid/domain/dashboard/service/query/DashboardQueryServiceTest.javasrc/test/java/com/opensource/docgrid/domain/embedding/repository/EmbeddingJobDashboardRepositoryTest.java
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET /admin/dashboard/summary추가 — 문서/인덱싱 작업/Worker/검색 현황을 하나의 응답으로 집계DocumentRepository/EmbeddingJobRepository/SearchQueryRepository에 읽기 전용 집계 쿼리 추가 (A 담당자 소유 테이블에 쓰기 없음)WorkerNodeQueryService.getWorkers()를 재사용해 Heartbeat 기반 상태 계산 로직을 중복 구현하지 않음avgProcessMs는 Queue 대기 시간(created_at)을 제외한 순수 처리 시간(started_at~completed_at)만 반영Test plan
DashboardQueryServiceTest단위 테스트 3건 통과 (지표 조합, avgProcessMs null 처리, Worker active count 필터링)EmbeddingJobDashboardRepositoryTestPostgreSQL@DataJpaTest3건 통과 (평균 처리시간 Native Query 검증)./gradlew build -x test클린 빌드 통과./gradlew test전체 회귀 테스트 통과 — 총 726개, failures 0, errors 0, skipped 0상세 설계
docs/design/kangcheolung-#134-ragops-dashboard-summary.mdcloses #134
🤖 Generated with Claude Code