fix(wf@894436a): tools@0.1.1 发包失败 + HttpDB/db.tx SOLID - #30
Closed
cursor[bot] wants to merge 1 commit into
Closed
Conversation
npm-publish 在 tag @sfmc-bds/tools@v0.1.1 失败:package.json 仍为 0.1.0。 同步 bump tools 到 0.1.1;空 authToken 回落平台默认(DIP);tx.call 改为 Promise<void> 并保留 tx 失败 step/code(LSP);publish 清单校验路径/name(DRY)。 Co-authored-by: Shiroha <Tanya7z@users.noreply.github.com>
cursor Bot
pushed a commit
that referenced
this pull request
Jul 22, 2026
npm-publish tag @sfmc-bds/tools@v0.1.1 曾因 package.json 仍为 0.1.0 失败。 同步 bump;HttpDB 空串回落平台默认;publish 清单校验路径/name。 Co-authored-by: Shiroha <Tanya7z@users.noreply.github.com>
Contributor
Author
There was a problem hiding this comment.
审查结论(本轮 push@894436a 后续)
本 PR 对 wf 失败(tools@0.1.1 版本漂移)与部分 SOLID(空 token / tx.call void / tx step-code)的修复方向正确。
建议:请优先合入(或关闭后改合)#31。#31 已吸收本 PR 的 wf/HttpDB/publish 门禁改动,并继续修了本 PR 正文「审查残留」里的 BLOCKER:
| 级别 | 原则 | #30 残留 | #31 |
|---|---|---|---|
| BLOCKER | DIP | set*ModuleContext 无注入 |
configs/all.module_tokens + bootModule 注入 |
| BLOCKER | DRY | — | configs/all.modules 不再恒 [] |
| MAJOR | OCP | — | ModuleId=string + id/configKey 双索引 |
| MAJOR | Demeter | config 单例互踩 | configKey 分桶 Map |
| MINOR | LSP | tx.update patch as U |
录制期 Promise<void> |
合入 #31 后对 @sfmc-bds/tools@v0.1.1 做 workflow_dispatch(checkout 默认分支)即可真正发包。
Sent by Cursor Automation: SFMC-Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
npm-publishrun 29928821721 失败:tag@sfmc-bds/tools@v0.1.1指向的 commit 里tools/package.json仍是0.1.0。修复
@sfmc-bds/toolsbump0.1.0→0.1.1(对齐已打 tag)HttpDB.resolveAuthToken— 空串不再用??阻断平台默认 tokentx.call改为Promise<void>(去掉undefined as U);post保留 tx 失败信封的step/code;去掉 post 成功后的死!ok分支set*ModuleContext时 fail-fast(对齐 config)assertPublishPackageInWorkspaces额外校验清单路径存在 +name一致;resolve-tag 版本不匹配时打印 workflow_dispatch 修复指引合入后如何真正发出 0.1.1
现有 tag
@sfmc-bds/tools@v0.1.1仍指向旧 commit(含 0.1.0)。请任选:@sfmc-bds/tools@v0.1.1做workflow_dispatch(checkout 默认分支,已含 0.1.1)审查残留(未改,下轮)
setDb/Config/ServiceModuleContext全仓无调用;module-tokens.json无 SAPI 注入路径;AFKconfig.get必炸_configKey),多模块会互相覆盖tx.update仍返回patch as U;平台 legacysuccess方言验证
PUBLISH_TAG=@sfmc-bds/tools@v0.1.1 node tools/resolve-npm-publish-tag.mjs→ Version OKnpm run typecheck -w @sfmc-bds/sdk通过SFMC_ROOT=$PWD node tools/check-ootb.mjs→ 11/11