fix(wf@3d15949): TS6133 MODULE_HELP_LABEL + enable 热同步 token/enabledSet - #36
Merged
Tanya7z merged 5 commits intoJul 22, 2026
Merged
Conversation
MAJOR DIP: setModuleEnabled 后同步 enabledSet、enabledManifests、 moduleAuth.tokens 与 builtin handlers,使「只重启 BDS」可用新 token。 MAJOR LSP: configs/all.banned_items 改为 string[](与 ConfigManager 契约对齐); resolveModuleByKey 省略 canDisable 视为可禁用(与 list 同源)。 Co-authored-by: Shiroha <Tanya7z@users.noreply.github.com>
Record<string,string> 允许动态增删 feature-b token,避免 tsc 窄化报错。 Co-authored-by: Shiroha <Tanya7z@users.noreply.github.com>
Contributor
Author
There was a problem hiding this comment.
Stale comment
审查结论(本 PR)
合入 #33 后 ootb Build 因
MODULE_HELP_LABEL死代码 →TS6133失败。本 PR 修复该 BLOCKER,并交付并行 #34/#35 未覆盖的 MAJOR DIP(enable 热同步 token/enabledSet)。
级别 原则 项 BLOCKER DRY MODULE_HELP_LABEL = paintModuleCmdAlias(c.green)一次复用MAJOR DIP syncModuleRuntimeState热更 enabledSet/manifests/tokens/builtinsMAJOR LSP banned_itemsstring[] +moduleCanDisable同源MINOR LSP ConfigManager 兼容 {item_id};service.get保留 code;ootb 锁形状本地:
buildPASS ·db-servertests 10/10 ·check-ootb11/11。建议合 #36,关闭重复 #34/#35。 剩余设计债:
db.tx两阶段读回、legacy{success}方言。Sent by Cursor Automation: SFMC-Review
This was referenced Jul 22, 2026
Tanya7z
marked this pull request as ready for review
July 22, 2026 17:23
Contributor
Author
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This was referenced Jul 22, 2026
Prefer syncModuleRuntimeState (DIP) over inline syncRuntimeEnabled; DRY onto module-auth/builtin-handlers helpers. Keep both sides' runtime tests. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
There was a problem hiding this comment.
审查(push main@85815c2 = merge #36)· DRY/OCP/DIP/LSP/Demeter
CI
ootbrun 29944458105 → success(Build / check-ootb / smoke-modules 全绿)- 此前 #37ec7986b 的 TS6133 Build 失败已被本 PR 合入修掉
本 PR 已覆盖(无需再改)
| 级别 | 原则 | 项 |
|---|---|---|
| DRY | MODULE_HELP_LABEL TS6133 |
|
| DIP | syncModuleRuntimeState 热同步 token/enabledSet/builtins |
|
| LSP | banned_items → string[];moduleCanDisable list/disable 同源 |
合入后仍可验证、已另开补丁
| 级别 | 原则 | 项 | 补丁 |
|---|---|---|---|
| MAJOR | DRY/OCP | builtin-handlers.serviceNames 与 registerEconomyHandlers 双写;热卸装应跟 registry.moduleId |
#41 |
| MINOR | OCP/DRY | db/tx 四份 session try/catch 复制 |
#41 |
| MINOR | Demeter | cleanupModule 无差别 clear*ModuleContext() 误清其他模块 config 桶 |
#41 |
建议
未发现新的 BLOCKER。
Sent by Cursor Automation: SFMC-Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
合入 #33 后
ootb在 Build 阶段失败:sfmc/src/repl.ts遗留未使用的MODULE_HELP_LABEL→TS6133(noUnusedLocals)。同时补上审查发现的可验证 SOLID 债:
paintModuleCmdAlias一次染色为MODULE_HELP_LABEL;删除未使用的MODULE_CMD_ALIAS_LABELsetModuleEnabled后同步enabledSet/enabledManifests/moduleAuth.tokens/ builtin handlers(抽module-runtime-sync.ts)configs/all.banned_items改为string[](与 ConfigManager 契约对齐)resolveModuleByKey省略canDisable视为可禁用(与 list 同源)Test plan
npm run build --workspaces --if-presentcd db-server && npm test(含syncModuleRuntimeState新用例,10/10)SFMC_ROOT=$PWD node tools/check-ootb.mjs→ 11/11 PASSOut of scope
{success}方言全量迁移