fix: contracts 精简后 economy 类型内聚 + 解除 qqutil 环依赖 - #46
Merged
Tanya7z merged 3 commits intoJul 23, 2026
Conversation
SDK 移除 economy 契约后 db-server 仍从 @sfmc-bds/sdk/contracts 导入， 导致 ootb 在 emitDeclarationOnly 阶段失败。行模型改由表所有者本地定义 （DIP/DRY），并同步 contracts 文档描述。 Co-authored-by: Shiroha <Tanya7z@users.noreply.github.com>
qqutil 误从 check-update 取 log 形成环依赖（Demeter/DIP）；改回 log.js。 preferredPowerShell 现返回完整 sfmc commandline，保留已发现的 pwsh 绝对路径 并加引号，避免 Program Files 路径与 PATH 不一致。 Co-authored-by: Shiroha <Tanya7z@users.noreply.github.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
Author
There was a problem hiding this comment.
审查结论（push main@0990780 / 742e32b）
| 级别 | 原则 | 项 | 本 PR |
|---|---|---|---|
| BLOCKER | DIP/DRY | economy 行类型从已删 SDK contracts 导入 → ootb 红 | ✅ 迁入 domain/economy.ts |
| MAJOR | Demeter/DIP | qqutil↔check-update 环依赖取 log |
✅ 改回 ./log.js |
| MAJOR | LSP | SEA 终端 commandline 丢绝对路径 | ✅ preferredSfmcCommandline |
| MINOR | DRY | contracts 文档漂移 | ✅ |
WF：main ootb 29991000606 红；本 PR ootb 29991280475 绿。
与 #47 重叠：#47 仅 economy 子集；请合本 PR，关闭 #47。
Sent by Cursor Automation: SFMC-Review
Tanya7z
self-requested a review
July 23, 2026 11:09
Tanya7z
marked this pull request as ready for review
July 23, 2026 11:15
Contributor
Author
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
main@0990780从 SDK 移除 economy 契约后，db-server仍从@sfmc-bds/sdk/contracts导入EconomyAccountRow/EconomyTransactionRow，ootbBuild all workspaces在tsc --emitDeclarationOnly失败（run 29991000606）。行模型改由表所有者db-server/src/domain/economy.ts本地定义（DIP/DRY）。qqutil.ts误从check-update.ts取log，与check-update → qqutil形成循环依赖；改回./log.js，并撤销check-update上多余的export const log。preferredPowerShell实际返回完整… -Command sfmccommandline；重命名为preferredSfmcCommandline，保留已发现的 pwsh 绝对路径并加引号，避免Program Files安装不在 PATH 时启动失败。审查维度
Test plan
npm run build --workspaces --if-presentnpm test -w @sfmc-bds/db-server（13/13）npm test -w @sfmc-bds/bds-tools（6/6）SFMC_ROOT=$PWD node tools/check-ootb.mjs（11/11）