Skip to content

fix(ci): eslint-plugin configs 漏交 + 移除残缺 land(post-#47 main) - #49

Merged
Tanya7z merged 1 commit into
mainfrom
cursor/bc-c934ab5a-a8e6-4f20-b7f2-1adb835cb742-f52d
Jul 23, 2026
Merged

fix(ci): eslint-plugin configs 漏交 + 移除残缺 land(post-#47 main)#49
Tanya7z merged 1 commit into
mainfrom
cursor/bc-c934ab5a-a8e6-4f20-b7f2-1adb835cb742-f52d

Conversation

@cursor

@cursor cursor Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

触发

ootb 在 main@eb58194(Merge #47)失败:run 30002066402

@sfmc-bds/eslint-plugin: error TS2307: Cannot find module './configs/recommended.js'

同源问题亦见于 #47 合并前的 25f6d23 / 3e6f0e8#48 已覆盖);本 PR 基于 post-#47 main 重做,并更干净地清理 package-lock

审查(DRY · OCP · DIP · LSP · Demeter)

级别 原则 问题
BLOCKER DRY .gitignoreconfigs/ 误伤 **/configs/**recommended.ts 从未入库 → CI TS2307
BLOCKER DIP / LSP 主仓 packages/land 声明 requires: feature-economy 且依赖旁路 sfmc-modules/economy,economy 未安装 → check-modules / 启动闭包失败
MINOR LSP ESLint 10 Plugin.rules@typescript-eslint RuleModule 类型边界需断言
正向 OCP / DIP 规则注册表 + createFlatConfig 工厂;业务模块外置、开箱仅 afk fixture

补丁

  1. .gitignoreconfigs//configs/
  2. 补齐 modules/sdk/@sfmc-eslint-plugin/src/configs/recommended.ts(及 dist)
  3. plugin as unknown as ESLint.Plugin 对齐类型边界
  4. 移除残缺 in-repo modules/packages/land,恢复 afk-only catalog/lock
  5. 相对 fix(ci): eslint-plugin configs 漏交 + 移除残缺 land 恢复 ootb #48:从 package-lock.json 删除 land/economy 包条目(而非仅标 extraneous

land / economy 仍应从 Tanya7z/sfmc-modulesfetch-module install 安装。

#48 关系

验证

npm run build --workspaces --if-present   # PASS
SFMC_ROOT=$PWD npm run check-ootb        # 12/12 PASS
Open in Web View Automation 

#48 已修复 eslint-plugin configs 漏交与残缺 land,但 package-lock
仍保留 modules/packages/land 与旁路 sfmc-modules/economy 包条目
(标记 extraneous)。彻底删除,避免假依赖信号(DRY)。

Co-authored-by: Shiroha <Tanya7z@users.noreply.github.com>
@cursor
cursor Bot force-pushed the cursor/bc-c934ab5a-a8e6-4f20-b7f2-1adb835cb742-f52d branch from 1ae53db to e02265b Compare July 23, 2026 11:16
@Tanya7z
Tanya7z marked this pull request as ready for review July 23, 2026 11:17
@cursor

cursor Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@Tanya7z
Tanya7z merged commit 4b3d83a into main Jul 23, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants