Skip to content

fix: relax Node.js engine requirement to support Node 20#43

Merged
frankieyan merged 2 commits intomainfrom
frankieyan/node-version-check
Jan 26, 2026
Merged

fix: relax Node.js engine requirement to support Node 20#43
frankieyan merged 2 commits intomainfrom
frankieyan/node-version-check

Conversation

@frankieyan
Copy link
Copy Markdown
Member

Relaxes the Node.js engine requirement from ^22.22.0 || >=24.13.0 to ^20.0.0 || >=22.0.0.

The previous restriction was overly conservative. Analysis of the codebase shows:

  • No Node 22-specific APIs are used — only standard APIs available since Node 12-14 (node:fs, node:path, node:child_process, node:url)
  • Runtime dependencies support Node 20 — the most restrictive is glob@13.0.0 which requires 20 || >=22
  • Dev dependency restrictions shouldn't affect consumers — stricter requirements from vitest and lint-staged only apply to contributors

Relaxes the Node.js engine requirement from `^22.22.0 || >=24.13.0`
to `^20.0.0 || >=22.0.0`.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@frankieyan frankieyan requested a review from a team as a code owner January 26, 2026 22:19
@frankieyan frankieyan requested review from Bloomca and removed request for a team January 26, 2026 22:19
Copy link
Copy Markdown

@doistbot-app doistbot-app Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request effectively updates the Node.js engine requirement in package-lock.json to include Node 20, consistent with the stated aim of broadening version support. The observed removal of numerous platform-specific optional dependencies is an expected outcome of regenerating the lock file following this change, and the PR description confirms that these modifications do not negatively impact consumers.

@frankieyan frankieyan added the 👀 Show PR PR must be reviewed before or after merging label Jan 26, 2026
The lockfile was regenerated on macOS which excluded Linux/Windows
optional dependencies needed for CI. Regenerated to include all
platform-specific binaries for biome, esbuild, and rollup.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@frankieyan frankieyan merged commit ba12784 into main Jan 26, 2026
2 checks passed
@frankieyan frankieyan deleted the frankieyan/node-version-check branch January 26, 2026 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

👀 Show PR PR must be reviewed before or after merging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant