feat: show errors with --show-errors regardless of increase#49
Merged
frankieyan merged 2 commits intomainfrom Jan 30, 2026
Merged
feat: show errors with --show-errors regardless of increase#49frankieyan merged 2 commits intomainfrom
frankieyan merged 2 commits intomainfrom
Conversation
Previously, --check-files and --stage-record-file with --show-errors would only display detailed errors when errors had increased. Now errors are shown for all checked files that have errors, matching the behavior of check-all. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
There was a problem hiding this comment.
This change correctly updates the --show-errors flag to consistently display detailed error information for all checked files, regardless of whether there is an increase in errors. The implementation is sound and the accompanying integration tests thoroughly validate the new behavior, improving the tool's consistency and making its output more predictable for users.
- Clarify that --show-errors displays errors regardless of increase - Add example showing errors when no increase - Rename "Detailed errors:" heading to "Errors:" for brevity Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
--check-filesand--stage-record-filewith--show-errorswould only display detailed errors when errors had increased. This made it inconsistent withcheck-all, which always shows errors when the flag is set.Now
--show-errorsdisplays errors for all checked files that have errors, regardless of whether there's an increase:Test plan
Test locally by running against the sample project fixtures:
npm run build cd src/__fixtures__/sample-projectCreate baseline records first
--check-files --show-errorsshows errors even with no increase--stage-record-file --show-errorsshows errors even with no increaseErrors still shown when there IS an increase (without baseline records)