Skip to content

ci: add reusable CI validation workflow and run it before releases#1032

Merged
rfgamaral merged 1 commit intomainfrom
ricardo/ci-validation-workflow
Apr 8, 2026
Merged

ci: add reusable CI validation workflow and run it before releases#1032
rfgamaral merged 1 commit intomainfrom
ricardo/ci-validation-workflow

Conversation

@rfgamaral
Copy link
Copy Markdown
Member

Short description

The existing PR workflow ran linting, type checking, tests, and build sequentially in a single job. This PR replaces it with a reusable CI validation workflow that runs these in parallel, matching Typist's structure.

More importantly, the release workflow now calls this validation before publishing. Previously, code was only validated on the PR, but by the time it merges to main, other PRs may have landed and the merge commit itself was never validated. Running CI validation before publishing ensures we don't release broken code.

@rfgamaral rfgamaral self-assigned this Apr 8, 2026
@rfgamaral rfgamaral added the 👀 Show PR Used for PRs that need a review, but can be merged when CI is green. label Apr 8, 2026
Copy link
Copy Markdown
Member

@doistbot doistbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR introduces a reusable CI validation workflow that parallelizes code checks and integrates them into the release pipeline to validate merge commits before publishing. Mirroring Typist's structure improves execution speed, while validating right before a release adds a strong safeguard for code quality. A few adjustments could further strengthen the setup, specifically by adding the reopened trigger to pull requests to prevent stale checks, restricting job permissions to enforce least privilege, and removing inherited secrets from the validation step to minimize credential exposure.

Share FeedbackReview Logs

@rfgamaral rfgamaral force-pushed the ricardo/ci-validation-workflow branch from b1541f5 to 27b7e88 Compare April 8, 2026 07:46
Replace the single-job pull_request workflow with a reusable CI
validation workflow that splits linting, type checking, testing, and
building into parallel jobs. The release workflow now calls this before
publishing, ensuring the merged code on main is validated before a
release is published.
@rfgamaral rfgamaral force-pushed the ricardo/ci-validation-workflow branch from 27b7e88 to dee18fe Compare April 8, 2026 07:57
@rfgamaral rfgamaral merged commit 15ecb4c into main Apr 8, 2026
8 of 9 checks passed
@rfgamaral rfgamaral deleted the ricardo/ci-validation-workflow branch April 8, 2026 08:00
@rfgamaral rfgamaral requested review from a team and Bloomca and removed request for a team April 8, 2026 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

👀 Show PR Used for PRs that need a review, but can be merged when CI is green.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants