feat: add modal close completion callback - #1148
Merged
Merged
Conversation
doistbot
reviewed
Aug 4, 2026
doistbot
left a comment
doistbot
left a comment
Member
There was a problem hiding this comment.
Adds onCloseComplete to Modal — a callback that fires once after a committed open-to-closed transition, when the modal and its focus lock have unmounted.
Few things worth tightening:
- Consider switching from
useLayoutEffecttouseEffect: since this invokes consumer-provided code synchronously before paint, any nontrivial handler delays the visible close. A passive effect still guarantees the DOM removal has committed, which is all that's required. - In the test, add an assertion that the dialog is present after the opening
rerenderbefore checking it's gone. Without verifying the modal actually mounted, the unmount assertions can pass vacuously.
gnapse
requested review from
a team and
rfgamaral
and removed request for
a team
August 4, 2026 15:30
doist-release-bot Bot
pushed a commit
that referenced
this pull request
Aug 4, 2026
## [36.1.0](v36.0.0...v36.1.0) (2026-08-04) ### Features * add modal close completion callback ([#1148](#1148)) ([d1c02c1](d1c02c1))
Contributor
|
🎉 This PR is included in version 36.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
Adds
onCloseCompletetoModal. The callback runs once after a committed open-to-closed transition, when the modal and its focus lock have unmounted.PR Checklist