Conversation
gnapse
requested review from
craigcarlyle,
frankieyan,
henningmu and
vishnugopal
* Update all of eslint and prettier packages. * Allow exceptions to jest/valid-title. Co-authored-by: Ernesto García <ernesto@doist.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
This is done in the context of upgrading to the latest reakit alpha (in order to be able to use their new Combobox component in our apps, and soon in Reactist hopefully).
At the same time I took the opportunity to upgrade various other dependencies, mostly harmless ones, or ones for which there was an easy check that they'd be breaking nothing (e.g. test-related dependencies with tests passing, type related dependencies with type checking passing, etc.)
PR Checklist
Added tests for bugs / new features(N/A)Updated docs (storybooks, readme)(N/A)npm run validateand made sure no errors / warnings were shownCHANGELOG.mdpackage.jsonnpm run build-all)Versioning
This will generate a new patch release number.