Fix @typescript-eslint/unbound-method by using class property arrow.#359
Merged
Fix @typescript-eslint/unbound-method by using class property arrow.#359
Conversation
Contributor
For this reason I request that we do not merge it right now. I'm about to perform a release soon and would like more time to check this change locally against both Todoist and Twist. |
Member
Author
|
@gnapse Makes sense, please merge it when you find it convenient. |
Member
Author
|
We could also consider ignoring existing occurrences, but given it's only few and that it sometimes produces real issues (we have one or two in twist-web) I think cleanup makes sense. |
Contributor
|
I added a task for myself to not loose track of this. Will come back to it after I release #356. |
proxi
force-pushed
the
proxi/unbound-method
branch
from
868c208 to
4c754ef
Compare
proxi
force-pushed
the
proxi/unbound-method
branch
from
4c754ef to
34ebeae
Compare
Member
Author
|
@gnapse Can it be merged now? |
gnapse
approved these changes
Jan 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
Fix
@typescript-eslint/unbound-methodrule violations and re-enable the rule in preparation to adopt shared eslint-config. For context, see discussion in here.The fix uses class property syntax. I know we've had some problems with transpiling it in other projects, so please double-check it's ok. I've run the tests and stories and checked output in es directory.
PR Checklist
npm run validateand made sure no errors / warnings were shownnpm run build-all)Versioning
It only affects internals and does not require release of its own.