fix: Prevent non-CSS modules from being treated as one#464
Merged
frankieyan merged 7 commits intobetafrom Mar 10, 2021
Merged
Conversation
frankieyan
force-pushed
the
frankie/fix-css-output
branch
from
a3b8335 to
116057c
Compare
frankieyan
requested review from
a team and
rfgamaral
and removed request for
a team
rfgamaral
approved these changes
Mar 9, 2021
frankieyan
force-pushed
the
frankie/fix-css-output
branch
from
116057c to
dcdeaf7
Compare
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
This fixes an issue where every css file being bundled were being treated as modules, causing the stylesheets to no longer match the classnames the components are using.
I've opened two issues with rollup-plugin-styles package so we may be able to remove the patches introduced here:
Anidetrix/rollup-plugin-styles#166
Anidetrix/rollup-plugin-styles#167
PR Checklist
npm run validateand made sure no errors / warnings were shownCHANGELOG.mdpackage.jsonandpackage-lock.json(npm --no-git-tag-version version <major|minor|patch>) refnpm run build-all)Versioning
This should be released as 9.1.0-beta.1