fix: Move patch-package to dependencies#467
Merged
frankieyan merged 1 commit intobetafrom Mar 11, 2021
Merged
Conversation
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
With #464 I added patch-package in order to patch rollup-plugin-style, however when being installed as a package with
npm ci, patch-package will not be available and the install will exit.This moves patch-package to our dependencies so that it'd be available. When installing as a package, it will omit patching dev dependencies, so other than the extra package being installed, there should be no additional consequences: ref
The alternative is to run patch-package with the
preparescript, which sounds like it covers all the scenarios that we would want it to run in, however, patch-package used to recommend the prepare script and have since changed it to postinstall: ds300/patch-package@f9fb13b.Test Plan
While not exactly the same as installing off of the registry, we can try installing this off of git and seeing the postinstall script run:
npm install git://github.com/doist/reactist#frankie/fix-patch-packagerm -rf node_modulesnpm ciWhereas if you try the steps above with v9.1.0-beta.1, it should fail
PR Checklist
npm run validateand made sure no errors / warnings were shownCHANGELOG.mdpackage.jsonandpackage-lock.json(npm --no-git-tag-version version <major|minor|patch>) refnpm run build-all)Versioning
v9.1.0-beta.2