fix(ci): create release tags on the pushed commit instead of default branch - #4983
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
softprops/action-gh-releasecreates the version tag withouttarget_commitish, so the GitHub API places it on the default branch (canary) instead of the commit on main that was actually built. This is why the v0.29.14 tag pointed to a canary commit and its auto-generated notes listed unreleased features.target_commitish: ${{ github.sha }}pins the tag to the exact commit the workflow ran on.Greptile Summary
Pins newly created release tags to the exact workflow commit rather than the repository’s default branch.
target_commitish: ${{ github.sha }}to the GitHub release action.Confidence Score: 5/5
The PR appears safe to merge with no blocking or non-blocking issues identified.
The explicitly targeted commit is the same commit used for checkout, version extraction, and image builds, preserving release provenance across supported triggers.
Reviews (1): Last reviewed commit: "fix(ci): create release tags on the push..." | Re-trigger Greptile