fix: Block I/O and Network I/O monitoring charts not populating - #4998
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4578
recordAdvancedStatsstored the rawdocker statsstrings with units ("610kB","938169.55MB") inreadMb/writeMb/inputMb/outputMb, and the recharts area charts received them as numeric dataKeys →NaN→ empty charts. CPU/Memory worked because their charts already strip%/ parse units.monitoring/units.tswithtoMb/parseIoToMb/formatMb(pure module, shared by server and client likehostname-validation)recordAdvancedStatsnow stores numeric MB for block/network, fixing both container-level and server-level (getHostSystemStats) monitoringIn: 938.65 GBinstead ofIn MB: 938169.55MB)No migrations.
Greptile Summary
This PR normalizes Docker block and network I/O statistics to numeric megabytes before persistence while retaining compatibility with legacy string values.
Confidence Score: 5/5
The PR appears safe to merge with no concrete blocking or independently actionable non-blocking issues identified.
The new conversion helpers cover the units emitted by the repository's container and host monitoring paths, numeric values remain unchanged when rendered, and legacy persisted strings are parsed by both the charts and headers.
Reviews (1): Last reviewed commit: "fix: parse Block I/O and Network I/O sta..." | Re-trigger Greptile
Context used: