[codex] Move routing rules into workspaces#2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/workspaces/routesas the primary home for routing configuration, with Advanced/config route aliases redirecting there while preserving query params.internal/web/distoutput from git completely: no hashed assets, no sentinel file. Generated assets are ignored, clean targets delete the directory, and build/install paths generate the dashboard before Go binaries are compiled.internal/web/distwhile still embedding the generated dashboard whenever the web build has produced it.Validation
/workspaces/routesrenders Workspace Routing and Add rule;/advanced/routes?workspace=...redirects to/workspaces/routes?workspace=....rm -rf internal/web/dist && git ls-files internal/web/dist && go test ./internal/apirm -rf internal/web/dist && go test ./...cd web && npm run buildgit check-ignore -v internal/web/dist internal/web/dist/index.html internal/web/dist/assets/index-cLkyy6t-.jscd web && npm run lint(0 errors; existing warnings only)cd web && npm run test(23 files / 163 tests passed)task buildgo test -tags p2p ./internal/p2p/...bash scripts/test-install.sh(uses an isolated random local port and verifies dashboard response from the newly built binary)Notes
v23.11.0, so npm reports the project engine warning (^20.19.0 || ^22.12.0 || >=24.0.0), but the commands above passed.