Allow reordering of extra field choices - #1007
Merged
Merged
Conversation
Choice values could only be appended, so the only way to get a value into the right place was to remove everything after it and type it all back in. Both clients now render each choice with a grip: drag it, or focus it and press the left/right arrow keys, to move it. The backend already accepts a reordered list — it only refuses removals. Fixes #994
Donkie
enabled auto-merge
August 2, 2026 08:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #994.
Choice values could only be appended, so putting a value in the right place meant deleting everything after it and typing it back in. Each choice now has a grip handle: drag it, or focus it and press the left/right arrow keys, to move it. Done in both clients.
The backend already accepts a reordered list, it only refuses removals, so this is frontend only.
One catch worth knowing about: rc-select wraps every custom tag in a span that preventDefaults mousedown, which stops the browser from ever starting a drag. The tag stops propagation so the native drag survives.
Verified in a browser against a real backend in both clients: drag, arrow keys, adding a choice by typing, removing one, and the saved order round-tripping through the API.