fix: Persist subtitle font weight across app restarts - #1075
Merged
PartyDonut merged 2 commits intoAug 9, 2026
Merged
Conversation
Charlie284
marked this pull request as ready for review
August 1, 2026 22:25
PartyDonut
approved these changes
Aug 9, 2026
PartyDonut
left a comment
PartyDonut
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for fixing this.
Removed the test as currently we don't really need/run any tests. Which I probably should add at some point 😓 .
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Persist the selected subtitle font weight across app restarts.
SubtitleSettingsModelstoresFontWeight.value(for example,700for Bold), but deserialization compared the stored number with the enum index. The restored value therefore fell back to Normal. Deserialization now compares againstFontWeight.value, with regression coverage for a Bold serialization round trip.Issue Being Fixed
Fixes #1072
Screenshots / Recordings
Not applicable. This change only affects settings persistence.
Tested On
Checklist
Testing
flutter analyzeflutter test test/pip_manager_test.dart test/subtitle_settings_model_test.dartflutter build apk --debug --split-per-abi --flavor productionfontWeight:700remained persisted through two cold launches and force-stops