Pre-seed scaffolded bindings from secret names - #12
Merged
Conversation
mikesellitto
approved these changes
Sep 9, 2026
mikesellitto
left a comment
mikesellitto
left a comment
There was a problem hiding this comment.
fyi: conflicts with #11 on the starter config text, and starterConfigHead here still lists statsig and sentry. Whichever lands second reconciles.
| // operator edits real entries instead of a generic example. | ||
| source := proxy.NewDopplerSource(localConfig) | ||
| proxyConfig, created, err := proxy.LoadOrScaffold(proxyConfigPath, func() []string { | ||
| names, _ := source.List(context.Background()) |
There was a problem hiding this comment.
optional: a bad token here falls back to the generic stubs silently and the real error shows up a moment later from the engine. A LogWarning on the error would make the fallback visible, but the engine's failure covers it, so your call.
An explicit secret-to-upstream mapping is where most of these vulnerabilities get closed, but an operator faced with a blank example rarely writes one. On first run the scaffolded config now documents the binding shape (host/paths/methods) and lists one commented stub per secret in the user's own Doppler config, so they edit real names instead of transcribing a generic example. Every stub stays commented, so a fresh scaffold still injects nothing until a host is filled in; with no names reachable it falls back to the provider example. The existing --proxy-config flag already lets the file live anywhere.
amoses12
force-pushed
the
austin/scaffold-binding-template
branch
from
September 9, 2026 21:16
430ff03 to
c49b9e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An explicit secret-to-upstream mapping is where most of these vulnerabilities get closed, but an operator faced with a blank example rarely writes one. On first run the scaffolded config now documents the binding shape (host/paths/methods) and lists one commented stub per secret in the user's own Doppler config, so they edit real names instead of transcribing a generic example. Every stub stays commented, so a fresh scaffold still injects nothing until a host is filled in; with no names reachable it falls back to the provider example. The existing --proxy-config flag already lets the file live anywhere.