Can't use buff timer because it is missing a lot of spells #162
|
At least for Shaman, most of the highest level spells seem to be missing? I can't add the following spells to the timer: Talisman of Altuna Also, it would be nice to be able to change the name of the line that is being tracked. Rather than the "You feel much faster", I want it to say "Haste" for example. |
Replies: 2 comments
|
Both of these are real, and the second one turns out to be a data problem I can show you the size of. The missing spells — confirmedI checked all six against the buff catalog and every one is missing: Talisman of Altuna, Strength, Agility, Dexterity, Stamina, Spirit of the Puma. The catalog holds 262 spells, and the shaman line is only partly covered — Talisman of Kragg, Shadoo, the Beast, the Brute, the Cat, the Raptor, the Rhino and the Serpent are all there, so yours have simply never been added. Why it isn't just a list I can extend in five minutes: EQBuddy identifies buffs by the message the game prints, not by spell name, because that's all a log line gives it. So each entry needs the landing text, the wear-off text, and the duration — and several spells usually share one message (all four Talismans of the Beast/Brute/Cat line print the same thing). Guessing any of that would be worse than the gap, since a wrong duration produces a countdown that lies to you. The fastest way to close it, if you're willing: cast each of those and paste the lines your log shows. For Talisman of Altuna I'd need the landing line, and the wear-off line whenever it drops. Failing that, the eqlwiki pages for each spell carry both messages and the duration, and a link is just as good. Worth saying: the Strength/Agility/Dexterity/Stamina set are stat buffs whose messages are shared with other classes' versions, so those may need a little care to attribute — your log lines would settle it. Renaming the tracked line — you've found a real inconsistency, not just a preference"You feel much faster" is showing because that catalog entry's label is literally its message. Compare a properly-labelled one: I counted: 37 of the 163 entries have no real label and fall back to the raw message. Yours is one of them — its four spells are Alacrity, Celerity, Quickness and Swift Like The Wind, which is plainly the haste line and should say so. So there are two separate things here, and I think the first is the one that actually helps you:
I'd rather do (1) first and see whether (2) still feels necessary afterwards. Does that match what you were after, or is there a case where you'd want a name different from the correct one — a personal shorthand, or distinguishing two characters' setups? |
|
Fixed — and you found something bigger than six spells. David asked the obvious question I should have asked myself: can't we get these from the wiki? We already had them. All six were sitting in EQBuddy's spell harvest with real durations — Talisman of Altuna at 1h12m, Strength at 63 minutes — and the catalog builder was throwing them away. The filter was one line: only include a spell if the wiki says it's beneficial. But the wiki leaves that field blank on 200 of its 1,929 spell pages, and silence was being read as "not a buff". Your six were all blanks. The naive fix would have been much worse than the bug. Most of those blanks are debuffs — Asphyxiate, Beguile, Bonds of Force — and a debuff in the buff catalog would start a countdown on something you never cast. So a blank now has to earn its way in on two independent signals: the spell targets a friend or yourself, and the page calls it some kind of Buff. Both, because either alone lets something through. That admitted 42 spells, not 6. Yours plus the whole Endure/Resist line, Charisma, Health, Nimble, Deftness, Feet like Cat, Inner Fire, Furious Strength and more. Every one a Statistic, Resist or Proc Buff. The catalog went from 263 buffs across 163 landing lines to 305 across 192. On the naming — done too, and I owe you a correction. I said yesterday that 37 lines were showing the game's own message where a name belonged, and I fixed them. What I'd missed is that the catalog is generated and says so at the top: "regenerate, never hand-edit". My edits would have been silently wiped by the very next harvest. The names now live in the generator, so they survive — and the four newly-shared lines this change created are named there as well. So your two asks land together: the spells are there, and the lines say "Haste line" rather than "You feel much faster". Both ship in the next release. Thanks for the report — "most of the highest level spells seem to be missing" turned out to be a systematic gap rather than six oversights, and it wouldn't have been found by anyone reading the code. |
Fixed — and you found something bigger than six spells.
David asked the obvious question I should have asked myself: can't we get these from the wiki? We already had them. All six were sitting in EQBuddy's spell harvest with real durations — Talisman of Altuna at 1h12m, Strength at 63 minutes — and the catalog builder was throwing them away.
The filter was one line: only include a spell if the wiki says it's beneficial. But the wiki leaves that field blank on 200 of its 1,929 spell pages, and silence was being read as "not a buff". Your six were all blanks.
The naive fix would have been much worse than the bug. Most of those blanks are debuffs — Asphyxiate, Beguile, Bonds of Force — and a…