Bump RestSharp from 106.5.4 to 110 in /DripDotNet #19
Conversation
Bumps [RestSharp](https://github.com/restsharp/RestSharp) from 106.5.4 to 106.12.0. - [Release notes](https://github.com/restsharp/RestSharp/releases) - [Changelog](https://github.com/restsharp/RestSharp/blob/dev/releasenotes.md) - [Commits](https://github.com/restsharp/RestSharp/commits/106.12) --- updated-dependencies: - dependency-name: RestSharp dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
the
dependencies
BenSandeen
left a comment
BenSandeen
left a comment
There was a problem hiding this comment.
Changes mostly looks safe, although I am slightly concerned by one of the changes in 106.6: https://github.com/restsharp/RestSharp/blob/dev/releasenotes.md#1066
- Moved serialization to the client
Can someone more familiar with this code verify that this won't affect us?
I looks like he was maybe making note of moving some code around. I've never seen this repo before and I don't know C#, but I poked around for a bit to see if I could understand what he meant. |
I landed at that commit as well! I've spent a handful of minutes looking around at that commit and how we're using the code it touches. I can't confidently say it'll break things, but the stuff I've seen so far makes me think we should not merge in this update until we can prove that it'll be fine. |
|
Okay, if we want to incorporate this PR, we'll need to update this repo. We're using drip-dot-net/DripDotNet/DripClient.cs Line 28 in 3c80c95 but that bit of code seems to no longer exist: It looks like the file was just moved (all of the following commands were run from the root directory of the RestSharp repo that I've cloned): $ git checkout 106.12.0 # checking out the commit tagged as version 106.12.0
$ rg JsonDeserializer
src/RestSharp/Serializers/Json/JsonSerializer.cs
301: public class JsonDeserializer : JsonSerializer { }
test/RestSharp.Serializers.Tests/IssueCases/Issue_1444.cs
33: var actual = (new JsonDeserializer()).Deserialize<FilterBaseModel>(new RestResponse {Content = json});
docs/api/RestSharp.md
11382:### Class `JsonDeserializer
$ git checkout 0c173f27eb8a97a15e6fe5aa1b7d91d55ba4169a # The commit we found that was concerning
$ rg Version | rg 106
RestSharp/RestSharp.csproj: <Version>106.5.4</Version> # Confirming this is version 106.5.4
$ rg JsonDeserializer
CONTRIBUTING.md
13: * Changes to XmlDeserializer or JsonDeserializer must be accompanied by a unit test covering the change.
RestSharp/Serialization/Json/JsonSerializer.cs
358: public class JsonDeserializer : JsonSerializer { } |
|
I'm going to spend some time trying to get this to compile. It's been a while since I've done C#, but hopefully it shouldn't be too tricky |
|
I think we should be good. I got it to compile just by adding a |
|
I merged in a change that fixes the build issues, but I haven't run the tests yet, so we should probably hold off on merging this until I can get those set up and running |
|
When attempting to run the tests, I learned that we're on quite an old version of .Net. It would be nice to upgrade this, although I do not know how much effort this would require |
BenSandeen
changed the title
|
I've upgraded a few things with major help from Cody AI. Hopefully it'll work. Running the tests require us to have an API token and actually interact with our API, so I haven't been able to get them working. I might spend a bit of time getting trying to rework the tests, but not much I've been running the tests with the following command line: I'm currently getting 18 passing tests and 6 failures |
BenSandeen
changed the title
Bumps RestSharp from 106.5.4 to 108.0.0.
Release notes
Sourced from RestSharp's releases.
... (truncated)
Changelog
Sourced from RestSharp's changelog.
... (truncated)
Commits
You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot use these labelswill set the current labels as the default for future PRs for this repo and language@dependabot use these reviewerswill set the current reviewers as the default for future PRs for this repo and language@dependabot use these assigneeswill set the current assignees as the default for future PRs for this repo and language@dependabot use this milestonewill set the current milestone as the default for future PRs for this repo and languageYou can disable automated security fix PRs for this repo from the Security Alerts page.