v1.1.1 — keep-current fails loudly on unprocessable PRs - #7
Conversation
A blocked Dependabot PR we couldn't act on (gh pr comment failed, or its mergeStateStatus never resolved out of UNKNOWN after retries) was previously a silent green run. Track failures and exit non-zero so it's a visible red run. One bad PR no longer suppresses the others. (Code-review finding on PR #3.) set -e behavior verified locally across 6 scenarios.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe ChangesDependabot Workflow Failure Tracking
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Code-review follow-up to v1.1.0. The keep-current reusable previously stayed green even when it couldn't do its job — a
gh pr commentfailure or a PR whosemergeStateStatusnever resolved out of UNKNOWN was swallowed with only a::warning::.Fix: track a
failurescounter; increment on a failed rebase-comment and on UNKNOWN-after-retries;exit 1at the end if any occurred. One bad PR no longer suppresses processing of the rest. Verified locally (mocked gh/sleep) across 6 scenarios incl. theset -e+[ ] && breakconstruct.Ships as v1.1.1.
Summary by CodeRabbit