Skip to content

v1.1.1 — keep-current fails loudly on unprocessable PRs - #7

Merged
mcarter-astronautdev merged 1 commit into
mainfrom
fix/keep-current-fail-loud
Jun 17, 2026
Merged

v1.1.1 — keep-current fails loudly on unprocessable PRs#7
mcarter-astronautdev merged 1 commit into
mainfrom
fix/keep-current-fail-loud

Conversation

@mcarter-astronautdev

@mcarter-astronautdev mcarter-astronautdev commented Jun 17, 2026

Copy link
Copy Markdown
Member

Code-review follow-up to v1.1.0. The keep-current reusable previously stayed green even when it couldn't do its job — a gh pr comment failure or a PR whose mergeStateStatus never resolved out of UNKNOWN was swallowed with only a ::warning::.

Fix: track a failures counter; increment on a failed rebase-comment and on UNKNOWN-after-retries; exit 1 at the end if any occurred. One bad PR no longer suppresses processing of the rest. Verified locally (mocked gh/sleep) across 6 scenarios incl. the set -e + [ ] && break construct.

Ships as v1.1.1.

Summary by CodeRabbit

  • Chores
    • Enhanced error tracking and handling in automated dependency update workflows to improve overall reliability and failure detection.

A blocked Dependabot PR we couldn't act on (gh pr comment failed, or its
mergeStateStatus never resolved out of UNKNOWN after retries) was previously a
silent green run. Track failures and exit non-zero so it's a visible red run.
One bad PR no longer suppresses the others. (Code-review finding on PR #3.)
set -e behavior verified locally across 6 scenarios.
@coderabbitai

coderabbitai Bot commented Jun 17, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 5fb16c3b-c32a-4444-8dfd-a882d4340502

📥 Commits

Reviewing files that changed from the base of the PR and between c362604 and 70a0709.

📒 Files selected for processing (1)
  • .github/workflows/dependabot-keep-current.yml

Walkthrough

The dependabot-keep-current.yml workflow gains a failures counter initialized before the PR processing loop. Within the loop, unresolved mergeStateStatus (UNKNOWN after retries) and failed @dependabot rebase comments are each counted as failures. After the loop, the workflow exits with a non-zero code if any failures were recorded.

Changes

Dependabot Workflow Failure Tracking

Layer / File(s) Summary
Failures counter, detection, and non-zero exit
.github/workflows/dependabot-keep-current.yml
Initializes a failures counter before the PR loop. Increments it when mergeStateStatus stays UNKNOWN after retries or when the @dependabot rebase comment call fails. Exits the workflow run with a non-zero code if failures > 0 after all PRs are processed.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

  • DriverDigital/workflows#6: Modifies the same mergeStateStatus polling and @dependabot rebase comment loop that this PR extends with failure counting logic.

Poem

🐇 Hop, hop, through each PR I go,
Counting the failures, high and low.
No silent success when things go wrong—
A non-zero exit, loud and strong!
The workflow now speaks when rebases fail,
Little rabbit tracks every detail. 🌟

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly and clearly summarizes the main change: making the workflow fail loudly when encountering unprocessable PRs, which is the primary objective of this version update.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/keep-current-fail-loud

Comment @coderabbitai help to get the list of available commands and usage tips.

@mcarter-astronautdev
mcarter-astronautdev merged commit 9d0a595 into main Jun 17, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant