Skip to content

Limit application support to tablet#597

Merged
arthurbenemann merged 4 commits intoDroidPlanner:masterfrom
m4gr3d:feature_restrict_to_tablet
Jan 21, 2014
Merged

Limit application support to tablet#597
arthurbenemann merged 4 commits intoDroidPlanner:masterfrom
m4gr3d:feature_restrict_to_tablet

Conversation

@m4gr3d
Copy link
Member

@m4gr3d m4gr3d commented Jan 21, 2014

Minor update to restrict application support to tablet-like device while we're still working on the phone ui layouts.
This change will cause the application to be filtered in the Google Play store so that it's only visible to 7inch tablets, and above.

@arthurbenemann
Copy link
Member

I'm inclined to agree with you Fredia, I just want Jason opinion before
pushing this forward.

People will complain about it, but we will limit a lot of problems
generated on the public release. And when/if the UI is redesigned to handle
phones as well we can remove the restriction.
On Jan 21, 2014 4:17 AM, "Fredia Huya-Kouadio" notifications@github.com
wrote:

Minor update to restrict application support to tablet-like device while
we're still working on the phone ui layouts.
This change will cause the application to be filtered in the Google Play

store so that it's only visible to 7inch tablets, and above.

You can merge this Pull Request by running

git pull https://github.com/ne0fhyk/droidplanner feature_restrict_to_tablet

Or view, comment on, or merge it at:

#597
Commit Summary

  • merged with latest from upstream/master
  • updated manifest file to limit support only to tablet for the
    current version.
  • reverted to updated submodules version.
  • updated usb submodule to the correct commit.

File Changes

Patch Links:


Reply to this email directly or view it on GitHubhttps://github.com//pull/597
.

@jason4short
Copy link
Contributor

I agree for now, but getting phone support will be needed soon.
Jason

On Jan 20, 2014, at 10:24 PM, Arthur Benemann notifications@github.com wrote:

I'm inclined to agree with you Fredia, I just want Jason opinion before
pushing this forward.

People will complain about it, but we will limit a lot of problems
generated on the public release. And when/if the UI is redesigned to handle
phones as well we can remove the restriction.
On Jan 21, 2014 4:17 AM, "Fredia Huya-Kouadio" notifications@github.com
wrote:

Minor update to restrict application support to tablet-like device while
we're still working on the phone ui layouts.
This change will cause the application to be filtered in the Google Play

store so that it's only visible to 7inch tablets, and above.

You can merge this Pull Request by running

git pull https://github.com/ne0fhyk/droidplanner feature_restrict_to_tablet

Or view, comment on, or merge it at:

#597
Commit Summary

  • merged with latest from upstream/master
  • updated manifest file to limit support only to tablet for the
    current version.
  • reverted to updated submodules version.
  • updated usb submodule to the correct commit.

File Changes

Patch Links:


Reply to this email directly or view it on GitHubhttps://github.com//pull/597
.


Reply to this email directly or view it on GitHub.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arthurbenemann
Copy link
Member

I'll merge it now, and when we have a phone layout we can remove it.

arthurbenemann added a commit that referenced this pull request Jan 21, 2014
@arthurbenemann arthurbenemann merged commit b16cbc0 into DroidPlanner:master Jan 21, 2014
@m4gr3d m4gr3d deleted the feature_restrict_to_tablet branch February 21, 2014 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments