Skip to content

Update Springboot to 4.1.0 and improve nodeinfo animation#491

Merged
DropSnorz merged 2 commits into
v2from
chore/sb-4.1.0
Jul 7, 2026
Merged

Update Springboot to 4.1.0 and improve nodeinfo animation#491
DropSnorz merged 2 commits into
v2from
chore/sb-4.1.0

Conversation

@DropSnorz

Copy link
Copy Markdown
Owner

No description provided.

@coderabbitai

coderabbitai Bot commented Jul 7, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

NodeInfoController now embeds a SideBar component with expand/collapse/toggle methods and a close button, replacing direct visibility toggling. PluginsController delegates info-pane display to these new methods. Corresponding FXML layouts (NodeInfoView, PluginsView) are restructured to support the sidebar and close button.

Changes

Sidebar-based node info panel

Layer / File(s) Summary
NodeInfoController sidebar wiring
owlplug-client/src/main/java/com/owlplug/plugin/controllers/NodeInfoController.java
Constructs a SideBar anchored to nodeInfoContent, wires a closeButton to collapse it, binds its visibility to pluginInfoView, and adds public show(), hide(), toggleVisibility() methods.
PluginsController delegation to sidebar
owlplug-client/src/main/java/com/owlplug/plugin/controllers/PluginsController.java
Replaces the pluginInfoPane field with pluginsContainer and updates info-pane display/toggle logic to call nodeInfoController.show()/hide()/toggleVisibility().
FXML layout updates for sidebar
owlplug-client/src/main/resources/fxml/plugins/NodeInfoView.fxml, owlplug-client/src/main/resources/fxml/plugins/PluginsView.fxml
NodeInfoView switches to an HBox root with an inner AnchorPane content pane and a closeButton with icon; PluginsView replaces the fixed-size VBox wrapper with an anchored AnchorPane.

Estimated code review effort: 2 (Simple) | ~15 minutes

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant PluginsController
    participant NodeInfoController
    participant SideBar

    User->>PluginsController: select plugin/toggle info pane
    PluginsController->>NodeInfoController: show() / hide() / toggleVisibility()
    NodeInfoController->>SideBar: expand() / collapse() / toggle()
    User->>NodeInfoController: click closeButton
    NodeInfoController->>SideBar: collapse()
Loading
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive No PR description was provided, so there is nothing to assess against the changeset. Add a brief description of the Spring Boot upgrade and node info animation changes.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the main changes: a Spring Boot upgrade and node info animation improvements.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/sb-4.1.0

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@DropSnorz

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jul 7, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@DropSnorz DropSnorz self-assigned this Jul 7, 2026
@DropSnorz DropSnorz added this to the 2.0.0 milestone Jul 7, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@owlplug-client/src/main/java/com/owlplug/plugin/controllers/NodeInfoController.java`:
- Around line 73-79: The close button visibility is currently tied only to
pluginInfoView in NodeInfoController, so it disappears whenever
directoryInfoView, symlinkInfoView, or componentInfoView is shown. Update the
closeButton.visibleProperty binding in setNode() to reflect whether any of the
four info views is visible, and keep the existing mutual-exclusion logic in sync
so the button remains available for all node types.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 5cea5069-a01c-4937-be67-58b628bea9f1

📥 Commits

Reviewing files that changed from the base of the PR and between 7bc9024 and f6194fe.

⛔ Files ignored due to path filters (1)
  • owlplug-client/pom.xml is excluded by !**/*.xml
📒 Files selected for processing (4)
  • owlplug-client/src/main/java/com/owlplug/plugin/controllers/NodeInfoController.java
  • owlplug-client/src/main/java/com/owlplug/plugin/controllers/PluginsController.java
  • owlplug-client/src/main/resources/fxml/plugins/NodeInfoView.fxml
  • owlplug-client/src/main/resources/fxml/plugins/PluginsView.fxml

@DropSnorz DropSnorz merged commit 4fc40dd into v2 Jul 7, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant