Skip to content

corpus: mirror rvt-rs #217 — IFC4 attribute arity and storey binding - #3

Merged
DrunkOnJava merged 1 commit into
mainfrom
corpus/mirror-rvt-rs-217
Aug 30, 2026
Merged

corpus: mirror rvt-rs #217 — IFC4 attribute arity and storey binding#3
DrunkOnJava merged 1 commit into
mainfrom
corpus/mirror-rvt-rs-217

Conversation

@DrunkOnJava

@DrunkOnJava DrunkOnJava commented Aug 30, 2026

Copy link
Copy Markdown
Owner

rvt-rs #217 makes every emitted entity carry its full IFC4 attribute
list and binds storeys from element-record base elevations (11/11
elevations match Revit's export; 256/338 elements contained). Both
rvt-rs observations change (storey_count 12 -> 11, arity-complete
entities); verdicts stay PASS with the same surfaces because
IFCBUILDINGSTOREY is decoder_baseline. Index re-chained; validators pass.


Note

Low Risk
Test-corpus fixture and documentation updates only; verdicts remain PASS with levels still excluded as decoder_baseline.

Overview
Refreshes committed rvt-rs witness output for both g-2026-0001 and g-2026-0002 after upstream rvt-rs #217 (IFC4 full attribute lists) and #213 (storey discovery from partition bbox base elevations instead of Level name strings).

Observations now report 11 IFCBUILDINGSTOREY (was 12), 11 IFCRELCONTAINEDINSPATIALSTRUCTURE (was 1), higher IFCPROPERTYSINGLEVALUE / adjusted IFCLOCALPLACEMENT, and storey_count 11. Warnings document elevation-derived storey labels, 256 elements bound by base elevation, and that 12 recovered Level names are not asserted; unsupported_geometry_missing_level falls from 274 to 18.

g-2026-0002/manifest.json counts.levels.notes is expanded to record the 12→11 change and elevation alignment with the Revit IFC export. MANIFEST_INDEX.json updates g-2026-0002 manifest_sha256, observation hashes, and chain_head after the manifest edit.

Reviewed by Cursor Bugbot for commit 2276628. Configure here.

rvt-rs #217 makes every emitted entity carry its full IFC4 attribute
list and binds storeys from element-record base elevations (11/11
elevations match Revit's export; 256/338 elements contained). Both
rvt-rs observations change (storey_count 12 -> 11, arity-complete
entities); verdicts stay PASS with the same surfaces because
IFCBUILDINGSTOREY is decoder_baseline. Index re-chained; validators pass.
@cursor

cursor Bot commented Aug 30, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_3fd40cf2-582e-4d43-8b62-85889c009b28)

@DrunkOnJava
DrunkOnJava merged commit 0f21961 into main Aug 30, 2026
5 checks passed
@DrunkOnJava
DrunkOnJava deleted the corpus/mirror-rvt-rs-217 branch August 30, 2026 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant