corpus: mirror rvt-rs #217 — IFC4 attribute arity and storey binding - #3
Merged
Conversation
rvt-rs #217 makes every emitted entity carry its full IFC4 attribute list and binds storeys from element-record base elevations (11/11 elevations match Revit's export; 256/338 elements contained). Both rvt-rs observations change (storey_count 12 -> 11, arity-complete entities); verdicts stay PASS with the same surfaces because IFCBUILDINGSTOREY is decoder_baseline. Index re-chained; validators pass.
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_3fd40cf2-582e-4d43-8b62-85889c009b28) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rvt-rs #217 makes every emitted entity carry its full IFC4 attribute
list and binds storeys from element-record base elevations (11/11
elevations match Revit's export; 256/338 elements contained). Both
rvt-rs observations change (storey_count 12 -> 11, arity-complete
entities); verdicts stay PASS with the same surfaces because
IFCBUILDINGSTOREY is decoder_baseline. Index re-chained; validators pass.
Note
Low Risk
Test-corpus fixture and documentation updates only; verdicts remain PASS with levels still excluded as decoder_baseline.
Overview
Refreshes committed
rvt-rswitness output for bothg-2026-0001andg-2026-0002after upstream rvt-rs #217 (IFC4 full attribute lists) and #213 (storey discovery from partition bbox base elevations instead of Level name strings).Observations now report 11
IFCBUILDINGSTOREY(was 12), 11IFCRELCONTAINEDINSPATIALSTRUCTURE(was 1), higherIFCPROPERTYSINGLEVALUE/ adjustedIFCLOCALPLACEMENT, andstorey_count11. Warnings document elevation-derived storey labels, 256 elements bound by base elevation, and that 12 recovered Level names are not asserted;unsupported_geometry_missing_levelfalls from 274 to 18.g-2026-0002/manifest.jsoncounts.levels.notesis expanded to record the 12→11 change and elevation alignment with the Revit IFC export.MANIFEST_INDEX.jsonupdatesg-2026-0002manifest_sha256, observation hashes, andchain_headafter the manifest edit.Reviewed by Cursor Bugbot for commit 2276628. Configure here.