chore: complete the master to next rename and retire dev-* - #1026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR completes the repository-wide migration from the old default branch name master to the new default branch next, fixing breakages at the git ref layer (e.g., git checkout master, git clone -b master, workflow branch filters) across install/build entrypoints and documentation.
Changes:
- Updated user-facing installation/build defaults to track
nextinstead of the removedmasterref (installer script,dstackup, auth-mock Dockerfile). - Removed
masterfrom GitHub Actions workflow branch filters so CI triggers match the renamed default branch. - Updated documentation and canonical GitHub links to reference
next, including new contributor guidance on branch naming and how to migrate existing clones.
Reviewed changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Updates GitHub links to point at next instead of master. |
| os/yocto/layers/meta-dstack/recipes-core/dstack-tee-simulator/files/dstack-tee-simulator.service | Updates systemd unit Documentation= URL to next. |
| os/spec/artifact-manifest.schema.json | Updates schema $id URL to reference next. |
| dstack/verifier/README.md | Updates README links to SDK docs under next. |
| dstack/scripts/install.sh | Changes default git ref to next and updates the documented `curl |
| dstack/kms/auth-mock/Dockerfile | Changes default build ARG DSTACK_BRANCH to next for git clone --branch. |
| dstack/crates/dstackup/src/cli.rs | Updates dstackup default --source-ref from master to next. |
| docs/verification.md | Updates verifier repo link to next. |
| docs/tutorials/contract-deployment.md | Replaces master checkout instructions with next. |
| docs/tutorials/clone-build-dstack-vmm.md | Updates tutorial text/comments to expect next instead of master. |
| docs/onboarding.md | Updates installer raw.githubusercontent.com URLs to use next. |
| docs/attestation-tdx.md | Updates dstack-mr link to next. |
| CONTRIBUTING.md | Adds a Branches section describing next/release/vX.Y/dev-* and provides clone migration commands. |
| .github/workflows/vmm-ui.yml | Removes master from workflow branch filters. |
| .github/workflows/spdx-check.yml | Removes master from workflow branch filters (now next only). |
| .github/workflows/sdk.yaml | Removes master from workflow branch filters. |
| .github/workflows/rust.yml | Removes master from workflow branch filters. |
| .github/workflows/prek-check.yml | Removes master from workflow branch filters. |
| .github/workflows/mkosi-build.yml | Removes master from the push.branches filter (now next only). |
| .github/workflows/gateway-proxy-tests.yml | Removes master from workflow branch filters. |
| .github/workflows/docker-build-check.yml | Removes master from workflow branch filters. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The default branch was renamed
master->next. GitHub redirects more than expected, but not everything, and the gap is where the breakage is.Measured after the rename:
github.com/.../blob|tree/master/...nextpathraw.githubusercontent.com/.../master/...raw/nextrepos/.../branches/masternextgit ls-remote refs/heads/mastergit fetch origin mastercouldn't find remote ref mastergit clone -b master <url>Remote branch master not found in upstream originSo documentation links were never broken, but anything that pins the ref name at the git layer broke the moment the rename landed. Three such places exist in this repo, and all three are on user-facing install/build paths:
dstack/scripts/install.sh—DEFAULT_REF="master", consumed asgit checkout "$ref"after cloning. This is the script behind the documentedcurl -fsSL .../install.sh | shentrypoint. The script runs underset -eu, so the failed checkout aborts the install outright. Reproduced against the live repo:dstack/crates/dstackup/src/cli.rs—DEFAULT_SOURCE_REF = "master", the clap default for--source-ref, consumed byinstall.rsas["checkout", git_ref]on both the cached-source and fresh-clone paths. Same failure.dstack/kms/auth-mock/Dockerfile—ARG DSTACK_BRANCH=masterfeedinggit clone --branch ${DSTACK_BRANCH}. This is exactly thegit clone -b mastercase measured above, so the image build fails at that layer.The docs under
docs/tutorials/also instruct readers to rungit checkout master, which now errors.Fix
Three commits, each independently readable:
ci: drop master from workflow branch filters— removes the now-deadmasterentry from all eight workflows.nextwas added in ci: add next to workflow branch filters #1025 before the rename so CI stayed green across the cutover; this removes the other half.fix: point default git refs at next— the three functional defaults above. This preserves the existing semantics of each knob (track the development mainline); it does not change what they track, only the name they track it by.ci: retire the dev-* branch pattern— drops thedev-*glob from the six workflows that carried it. The pattern is dead config:git ls-remote --heads origin 'refs/heads/dev-*'returns nothing and none of the last 100 workflow runs came from such a branch. All eight workflows now filter on exactly[next], so there is one rule instead of two. Working branches still get their checks through thepull_requesttrigger; only pushes to a branch with no open PR stop building, which nothing was relying on. (dstack-dev-*anddstack-nvidia-dev-*in the docs are image names, not branch patterns, and are untouched.)ci: run workflows on release branches— addsrelease/**to the eight filters. Note what this does and does not do: for bothpushandpull_request, GitHub runs the workflow files as they exist on the branch being built, so this cannot retroactively give CI torelease/v0.5.x(cut fromv0.5.11, whose filters predate the rename). It means any future release branch cut fromnextinherits working filters instead of needing the same fix again. Enabling CI on the existingrelease/v0.5.xis tracked separately.docs: update branch references to next— README, docs, tutorials, verifier README, the artifact-manifest$id, the simulator unit'sDocumentation=URL, and a new## Branchessection inCONTRIBUTING.mddescribingnext/release/vX.Y/dev-*plus the clone-migration one-liner.Deliberately not touched:
CHANGELOG.md— generated history; the old branch names are a factual record.dtolnay/rust-toolchain@master,rwf2/Rocket branch = "master",tianocore/edk2 branch=master, the sysbox doc link — third-party refs.ip link set dev <tap> master <bridge>invmm/src/netd.rsandbus_masterinlspci— kernel/PCI terminology.dstack/tests/docs/kms-self-authorization.md— prose recording what a past test ran against.Verification
cargo check -p dstackuppasses.sh -n dstack/scripts/install.shpasses.push/pull_requeston[next, release/**]uniformly across all eight, withmkosi-build'smkosi-os-v*tag trigger andpaths-onlypull_requestfilter unchanged.masteroutside vendoredos/yocto/deps/**: every remaining hit is in the deliberately-untouched list above.next, so its own check run confirmspull_requestdispatch works against the renamed branch.Follow-up
release/v0.5.xnow exists at thev0.5.11commit, protected against deletion and force-push. It has no CI: creating it triggered zero workflow runs, andmerge-protectiontargets~DEFAULT_BRANCHonly, so a backport PR into it currently faces no required checks. Its v0.5.11-era workflows are 1918 commits old and are not expected to pass unmodified on current runners, so which of them are worth reviving on that line is a separate decision.